From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Pihet Subject: Re: [PATCH] tracing, perf: add more power related events Date: Wed, 22 Sep 2010 17:36:04 +0200 Message-ID: References: <201009171736.14170.trenn@suse.de> <20100917162412.GB3341@elte.hu> <201009180026.59482.trenn@suse.de> <4C9A21AD.1000800@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4C9A21AD.1000800@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Arjan van de Ven Cc: Len Brown , linux-trace-users@vger.kernel.org, Peter Zijlstra , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-pm@lists.linux-foundation.org, discuss@lesswatts.org, Ingo Molnar , linux-omap@vger.kernel.org, arjan@infradead.org List-Id: linux-pm@vger.kernel.org On Wed, Sep 22, 2010 at 5:33 PM, Arjan van de Ven w= rote: > =A0On 9/22/2010 8:31 AM, Jean Pihet wrote: >> >> Hi, >> >> Here is a patch that redefines the power events API. The advantages >> are: easier maintainance of the kernel and the >> user space tools, a cleaner and more generic interface, more >> parameters for fine tracing and even documentation! >> >> Thomas, this patch has your patch above merged in ('power-trace: Use >> power_switch_state instead of power_start and power_end'). The revised >> ACPI patch is coming asap. >> >> The trace points for x86 and OMAP are also udated accordingly. >> >> The pytimechart tool needs an update for the new API. This can be done >> as soon as the kernel code gets merged in. > > unfortunately this code is changing a userspace ABI... we really shouldn't > do that if we can avoid it, > and here we can avoid it. > > applications ARE using this stuff! What are the apps that are using it? I know about builtin-timechart, pytimechart. Is powertop using this as well? Is it better to go for a 3 steps approach (add new API, change tools, deprecate old API) like proposed above? Thanks, Jean