From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37306 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Psyfa-0008TB-KD for qemu-devel@nongnu.org; Fri, 25 Feb 2011 09:29:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsyfZ-0005t8-Df for qemu-devel@nongnu.org; Fri, 25 Feb 2011 09:29:22 -0500 Received: from mail-ey0-f173.google.com ([209.85.215.173]:53590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsyfZ-0005t1-7S for qemu-devel@nongnu.org; Fri, 25 Feb 2011 09:29:21 -0500 Received: by eyb6 with SMTP id 6so628219eyb.4 for ; Fri, 25 Feb 2011 06:29:20 -0800 (PST) MIME-Version: 1.0 Sender: anthony.perard@gmail.com In-Reply-To: <4D67B81D.8000600@codemonkey.ws> References: <1296658172-16609-1-git-send-email-anthony.perard@citrix.com> <1296658172-16609-6-git-send-email-anthony.perard@citrix.com> <4D6695E6.7040004@codemonkey.ws> <4D67B81D.8000600@codemonkey.ws> From: Anthony PERARD Date: Fri, 25 Feb 2011 14:28:50 +0000 Message-ID: Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH V10 05/15] xen: Add xenfv machine Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Xen Devel , QEMU-devel , Stefano Stabellini On Fri, Feb 25, 2011 at 14:09, Anthony Liguori wrot= e: > On 02/25/2011 07:55 AM, Anthony PERARD wrote: >> >> On Thu, Feb 24, 2011 at 17:31, Anthony Liguori >> =C2=A0wrote: >> >>>> >>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >>>> index 7b74473..0ab8907 100644 >>>> --- a/hw/pc_piix.c >>>> +++ b/hw/pc_piix.c >>>> @@ -36,6 +36,10 @@ >>>> =C2=A0#include "sysbus.h" >>>> =C2=A0#include "arch_init.h" >>>> =C2=A0#include "blockdev.h" >>>> +#include "xen.h" >>>> +#ifdef CONFIG_XEN >>>> +# =C2=A0include "xen/hvm/hvm_info_table.h" >>>> +#endif >>>> >>>> >>> >>> Admittedly a nit, but isn't this a system header? >>> >> >> It belongs to Xen. I use it for HVM_MAX_VCPUS. >> >> I can put it in xen.h, if you prefer. >> > > I meant, you should use: > > #include Sure, I will do that. Thanks, --=20 Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: Re: [Qemu-devel] [PATCH V10 05/15] xen: Add xenfv machine Date: Fri, 25 Feb 2011 14:28:50 +0000 Message-ID: References: <1296658172-16609-1-git-send-email-anthony.perard@citrix.com> <1296658172-16609-6-git-send-email-anthony.perard@citrix.com> <4D6695E6.7040004@codemonkey.ws> <4D67B81D.8000600@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D67B81D.8000600@codemonkey.ws> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: Xen Devel , QEMU-devel , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Fri, Feb 25, 2011 at 14:09, Anthony Liguori wrot= e: > On 02/25/2011 07:55 AM, Anthony PERARD wrote: >> >> On Thu, Feb 24, 2011 at 17:31, Anthony Liguori >> =C2=A0wrote: >> >>>> >>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >>>> index 7b74473..0ab8907 100644 >>>> --- a/hw/pc_piix.c >>>> +++ b/hw/pc_piix.c >>>> @@ -36,6 +36,10 @@ >>>> =C2=A0#include "sysbus.h" >>>> =C2=A0#include "arch_init.h" >>>> =C2=A0#include "blockdev.h" >>>> +#include "xen.h" >>>> +#ifdef CONFIG_XEN >>>> +# =C2=A0include "xen/hvm/hvm_info_table.h" >>>> +#endif >>>> >>>> >>> >>> Admittedly a nit, but isn't this a system header? >>> >> >> It belongs to Xen. I use it for HVM_MAX_VCPUS. >> >> I can put it in xen.h, if you prefer. >> > > I meant, you should use: > > #include Sure, I will do that. Thanks, --=20 Anthony PERARD