From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755213Ab1A1Omu (ORCPT ); Fri, 28 Jan 2011 09:42:50 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:58454 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755032Ab1A1Oms (ORCPT ); Fri, 28 Jan 2011 09:42:48 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=OOM62gOix7cn9Ga32CBS1Vp5vRLeVAfeedQxCMunrz2D6Ytq+sN+vHO+VLIGSfThYF vVwqL4PTwtCjjz6dsF7e17anfr0F+B8NvMzSCHi0jteeuxaq4/kbnCHfKdlpQ9qNVF5T 3rBxno/DTRbqMPUUi0Niw4wfKq5PlDqmYW3hI= MIME-Version: 1.0 In-Reply-To: <20110127212001.GC4542@dumpdata.com> References: <1294420304-24811-1-git-send-email-konrad.wilk@oracle.com> <1294420304-24811-5-git-send-email-konrad.wilk@oracle.com> <20110127212001.GC4542@dumpdata.com> Date: Fri, 28 Jan 2011 09:42:48 -0500 Message-ID: Subject: Re: [PATCH 4/5] radeon/ttm/PCIe: Use dma_addr if TTM has set it. From: Jerome Glisse To: Konrad Rzeszutek Wilk Cc: dri-devel@lists.freedesktop.org, thomas@shipmail.org, airlied@linux.ie, linux-kernel@vger.kernel.org, Alex Deucher , Jerome Glisse , konrad@darnok.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2011 at 4:20 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 07, 2011 at 12:11:43PM -0500, Konrad Rzeszutek Wilk wrote: >> If the TTM layer has used the DMA API to setup pages that are >> TTM_PAGE_FLAG_DMA32 (look at patch titled: "ttm: Utilize the dma_addr_t >> array for pages that are to in DMA32 pool."), lets use it >> when programming the GART in the PCIe type cards. >> >> This patch skips doing the pci_map_page (and pci_unmap_page) if >> there is a DMA addresses passed in for that page. If the dma_address >> is zero (or DMA_ERROR_CODE), then we continue on with our old >> behaviour. > > Hey Jerome, > > I should have CC-ed you earlier but missed that and instead just > CC-ed the mailing list. I was wondering what your thoughts are > about this patchset? Thomas took a look at the patchset and he is OK > but more eyes never hurt. > > FYI, for clarity I hadn't made the old calls that got moved due > to adding of "{" checkpatch.pl compliant. It complains about it being > past 80 characters. I can naturally fix that up, but thought > that it might detract from the nature of the patch. What happen when we don't ask dma32 alloc to ttm ? Will this still work in virtualized environnement ? Code looks good but GART stuff can be picky, i will try to do a full scale testing in next couple week. Cheers, Jerome From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [PATCH 4/5] radeon/ttm/PCIe: Use dma_addr if TTM has set it. Date: Fri, 28 Jan 2011 09:42:48 -0500 Message-ID: References: <1294420304-24811-1-git-send-email-konrad.wilk@oracle.com> <1294420304-24811-5-git-send-email-konrad.wilk@oracle.com> <20110127212001.GC4542@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-iy0-f177.google.com (mail-iy0-f177.google.com [209.85.210.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D3839E765 for ; Fri, 28 Jan 2011 06:42:48 -0800 (PST) Received: by iyj21 with SMTP id 21so2729155iyj.36 for ; Fri, 28 Jan 2011 06:42:48 -0800 (PST) In-Reply-To: <20110127212001.GC4542@dumpdata.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Konrad Rzeszutek Wilk Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jerome Glisse , konrad@darnok.org List-Id: dri-devel@lists.freedesktop.org On Thu, Jan 27, 2011 at 4:20 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 07, 2011 at 12:11:43PM -0500, Konrad Rzeszutek Wilk wrote: >> If the TTM layer has used the DMA API to setup pages that are >> TTM_PAGE_FLAG_DMA32 (look at patch titled: "ttm: Utilize the dma_addr_t >> array for pages that are to in DMA32 pool."), lets use it >> when programming the GART in the PCIe type cards. >> >> This patch skips doing the pci_map_page (and pci_unmap_page) if >> there is a DMA addresses passed in for that page. If the dma_address >> is zero (or DMA_ERROR_CODE), then we continue on with our old >> behaviour. > > Hey Jerome, > > I should have CC-ed you earlier but missed that and instead just > CC-ed the mailing list. I was wondering what your thoughts are > about this patchset? Thomas took a look at the patchset and he is OK > but more eyes never hurt. > > FYI, for clarity I hadn't made the old calls that got moved due > to adding of "{" checkpatch.pl compliant. It complains about it being > past 80 characters. I can naturally fix that up, but thought > that it might detract from the nature of the patch. What happen when we don't ask dma32 alloc to ttm ? Will this still work in virtualized environnement ? Code looks good but GART stuff can be picky, i will try to do a full scale testing in next couple week. Cheers, Jerome