From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <4D5BF2E1.6070102@codeaurora.org> References: <1297891081-27976-1-git-send-email-bgix@codeaurora.org> <1297891081-27976-4-git-send-email-bgix@codeaurora.org> <4D5BF2E1.6070102@codeaurora.org> Date: Wed, 16 Feb 2011 13:38:42 -0300 Message-ID: Subject: Re: [PATCH 3/3] Add gatttool enhancements for UPF From: Anderson Lizardo To: Brian Gix Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@nokia.com, padovan@profusion.mobi Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Brian, On Wed, Feb 16, 2011 at 12:53 PM, Brian Gix wrote: > Hi Anderson, > > The modifications to gatttool were largely organic in nature and on the fly > responses to the needs of my UPF testing. Also, it is of course just a test > tool. Understood, but if you could split these changes into more "logic" pieces (separate commits), with commit messages which explain the reasoning of the change (e.g. the answers on this thread), it will be nice. Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil