From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757222Ab0HaMPP (ORCPT ); Tue, 31 Aug 2010 08:15:15 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:42082 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753598Ab0HaMPI (ORCPT ); Tue, 31 Aug 2010 08:15:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=to4CR7sXkabDnvJWj3fNsdOxc1qvc7HQJyJzWjvQZSBJZdPyQb3BUOXyGn8hp143gk M8OBC6cSEpR2l1HQ183z48kHN2bMlkQoYoNyuFLlthHlGODyed+VDhT8HEoD0rLadEl5 l/BhrpT0X1jio0pZk8JZ+Ci8OAcLtSUZOzCPo= MIME-Version: 1.0 In-Reply-To: <20100831110758.GD20849@rakim.wolfsonmicro.main> References: <1259844390-10541-1-git-send-email-daniel@caiaq.de> <20100827190306.GB20407@void.printf.net> <20100829132711.GB10233@opensource.wolfsonmicro.com> <20100831110758.GD20849@rakim.wolfsonmicro.main> Date: Tue, 31 Aug 2010 14:15:07 +0200 Message-ID: Subject: Re: [PATCH] mmc: move regulator handling to core From: Linus Walleij To: Mark Brown Cc: Chris Ball , Daniel Mack , linux-kernel@vger.kernel.org, Liam Girdwood , Pierre Ossman , Andrew Morton , Matt Fleming , Adrian Hunter , David Brownell , Russell King , Eric Miao , Robert Jarzmik , Cliff Brake , Jarkko Lavinen , Madhusudhan , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2010/8/31 Mark Brown : > On Sun, Aug 29, 2010 at 05:30:48PM +0200, Linus Walleij wrote: >> 2010/8/29 Mark Brown : > >> > This seems like the wrong approach; if there's a problem it'd seem much >> > better to fix the core code that everything is sharing rather than >> > factor it out - the location of the code is orthogonal to its >> > helpfulness. > >> I actually did not move the essential regulator bits out just enable/disable, >> so that these were in the sites where the regulators were actually >> enabled/disabled in respective driver. That makes the internal >> regulator reference count do the trick. > > I'm not sure what "the sites where the regulators were actually > enabled/disabled in respective driver" are but my understanding was that > there's a bit of an issue here in that the MMC core does not guarantee > balanced enable/disable calls. Yeah I figured out what you wanted and sent an updated patch, check it out. I'll just weave in some comments from Adrian and it'll do things the way you want it I believe. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] mmc: move regulator handling to core Date: Tue, 31 Aug 2010 14:15:07 +0200 Message-ID: References: <1259844390-10541-1-git-send-email-daniel@caiaq.de> <20100827190306.GB20407@void.printf.net> <20100829132711.GB10233@opensource.wolfsonmicro.com> <20100831110758.GD20849@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100831110758.GD20849@rakim.wolfsonmicro.main> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Brown Cc: Matt Fleming , David Brownell , Eric Miao , Jarkko Lavinen , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Adrian Hunter , Daniel Mack , Madhusudhan , Cliff Brake , Russell King , Andrew Morton , Chris Ball , Robert Jarzmik , Pierre Ossman , linux-arm-kernel@lists.infradead.org, Liam Girdwood List-Id: linux-mmc@vger.kernel.org 2010/8/31 Mark Brown : > On Sun, Aug 29, 2010 at 05:30:48PM +0200, Linus Walleij wrote: >> 2010/8/29 Mark Brown : > >> > This seems like the wrong approach; if there's a problem it'd seem much >> > better to fix the core code that everything is sharing rather than >> > factor it out - the location of the code is orthogonal to its >> > helpfulness. > >> I actually did not move the essential regulator bits out just enable/disable, >> so that these were in the sites where the regulators were actually >> enabled/disabled in respective driver. That makes the internal >> regulator reference count do the trick. > > I'm not sure what "the sites where the regulators were actually > enabled/disabled in respective driver" are but my understanding was that > there's a bit of an issue here in that the MMC core does not guarantee > balanced enable/disable calls. Yeah I figured out what you wanted and sent an updated patch, check it out. I'll just weave in some comments from Adrian and it'll do things the way you want it I believe. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.ml.walleij@gmail.com (Linus Walleij) Date: Tue, 31 Aug 2010 14:15:07 +0200 Subject: [PATCH] mmc: move regulator handling to core In-Reply-To: <20100831110758.GD20849@rakim.wolfsonmicro.main> References: <1259844390-10541-1-git-send-email-daniel@caiaq.de> <20100827190306.GB20407@void.printf.net> <20100829132711.GB10233@opensource.wolfsonmicro.com> <20100831110758.GD20849@rakim.wolfsonmicro.main> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2010/8/31 Mark Brown : > On Sun, Aug 29, 2010 at 05:30:48PM +0200, Linus Walleij wrote: >> 2010/8/29 Mark Brown : > >> > This seems like the wrong approach; if there's a problem it'd seem much >> > better to fix the core code that everything is sharing rather than >> > factor it out - the location of the code is orthogonal to its >> > helpfulness. > >> I actually did not move the essential regulator bits out just enable/disable, >> so that these were in the sites where the regulators were actually >> enabled/disabled in respective driver. That makes the internal >> regulator reference count do the trick. > > I'm not sure what "the sites where the regulators were actually > enabled/disabled in respective driver" are but my understanding was that > there's a bit of an issue here in that the MMC core does not guarantee > balanced enable/disable calls. Yeah I figured out what you wanted and sent an updated patch, check it out. I'll just weave in some comments from Adrian and it'll do things the way you want it I believe. Yours, Linus Walleij