From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Pihet Subject: Re: [PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM Date: Thu, 20 Jan 2011 14:14:40 +0100 Message-ID: References: <1295352126-29171-1-git-send-email-j-pihet@ti.com> <87vd1ksq2i.fsf@ti.com> <87mxmwr2un.fsf@ti.com> <20110119221056.GG4957@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:53889 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755565Ab1ATNOl convert rfc822-to-8bit (ORCPT ); Thu, 20 Jan 2011 08:14:41 -0500 Received: by qyj19 with SMTP id 19so1902888qyj.19 for ; Thu, 20 Jan 2011 05:14:40 -0800 (PST) In-Reply-To: <20110119221056.GG4957@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Kevin Hilman , Dave Martin , Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Jean Pihet On Wed, Jan 19, 2011 at 11:10 PM, Tony Lindgren wrot= e: > * Kevin Hilman [110119 13:37]: >> Kevin Hilman writes: >> >> > jean.pihet@newoldbits.com writes: >> > >> >> From: Jean Pihet >> >> >> >> The new fncpy API is better suited for copying some >> >> code to SRAM at runtime. This patch changes the ad-hoc >> >> code to the more generic fncpy API. >> >> >> >> Tested OK on OMAP3 in low power modes (RET/OFF) >> >> using omap2plus_defconfig with !CONFIG_THUMB2_KERNEL. >> >> Compile tested on OMAP1/2 using omap1_defconfig. >> >> >> >> Signed-off-by: Jean Pihet >> > >> > Acked-by: Kevin Hilman >> > >> > Boot tested on OMAP1 & OMAP2 as well. =A0Note that neither OMAP1 o= r OMAP2 >> > has had working suspend/resume for a long time now, so I did not t= est >> > suspend/resume. >> >> For OMAP2: >> >> Tested-by: Kevin Hilman >> >> to test a little more on OMAP2, I just removed the WFI from the >> low-level code and tested suspend that way. =A0That's enough to be s= ure >> the copied code is copied and executed. >> >> Worked fine on OMAP2420/n810. >> >> For OMAP1, this didn't work and would require more serious hacking o= n >> the OMAP1 suspend path, which I currently have no plans to do. > > Boots fine on osk5912 and n800 too: > > Tested-by: Tony Lindgren > Thanks for testing! Regards, Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jean.pihet@newoldbits.com (Jean Pihet) Date: Thu, 20 Jan 2011 14:14:40 +0100 Subject: [PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM In-Reply-To: <20110119221056.GG4957@atomide.com> References: <1295352126-29171-1-git-send-email-j-pihet@ti.com> <87vd1ksq2i.fsf@ti.com> <87mxmwr2un.fsf@ti.com> <20110119221056.GG4957@atomide.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 19, 2011 at 11:10 PM, Tony Lindgren wrote: > * Kevin Hilman [110119 13:37]: >> Kevin Hilman writes: >> >> > jean.pihet at newoldbits.com writes: >> > >> >> From: Jean Pihet >> >> >> >> The new fncpy API is better suited for copying some >> >> code to SRAM at runtime. This patch changes the ad-hoc >> >> code to the more generic fncpy API. >> >> >> >> Tested OK on OMAP3 in low power modes (RET/OFF) >> >> using omap2plus_defconfig with !CONFIG_THUMB2_KERNEL. >> >> Compile tested on OMAP1/2 using omap1_defconfig. >> >> >> >> Signed-off-by: Jean Pihet >> > >> > Acked-by: Kevin Hilman >> > >> > Boot tested on OMAP1 & OMAP2 as well. ?Note that neither OMAP1 or OMAP2 >> > has had working suspend/resume for a long time now, so I did not test >> > suspend/resume. >> >> For OMAP2: >> >> Tested-by: Kevin Hilman >> >> to test a little more on OMAP2, I just removed the WFI from the >> low-level code and tested suspend that way. ?That's enough to be sure >> the copied code is copied and executed. >> >> Worked fine on OMAP2420/n810. >> >> For OMAP1, this didn't work and would require more serious hacking on >> the OMAP1 suspend path, which I currently have no plans to do. > > Boots fine on osk5912 and n800 too: > > Tested-by: Tony Lindgren > Thanks for testing! Regards, Jean