From: Mohammed Shafi <shafi.wireless@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] AR5416 calibration / chainmask configuration bug?
Date: Mon, 31 Jan 2011 18:23:41 +0530 [thread overview]
Message-ID: <AANLkTimRdX7Ac4ajHtCq3WzJpevAXNSu3sCmuRGau-+o@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin--97Ec205M=WsH6sR3qZVzkxCRtU6rFY3b-mj@mail.gmail.com>
On Thu, Jan 27, 2011 at 3:16 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> Hi,
>
> In ar5008_phy.c:ar5008_hw_init_chain_masks(), some special case
> happens for AR5416 v1.0 when the chainmask is configured for two
> chains.
As per the reference hw code it's a workaround for that particular
version to meet calibration failure and later it seems we will obtain
the correct mask and this only happens for this particular chip.
>
> But the comparison seems bogus - it's checking if
> hw_version.macVersion == AR_SREV_REVISION_5416_10; it's comparing the
> revision rather than the MAC version. And since
> AR_SREV_REVISION_5416_10 is defined as 0, the macVersion would have to
> be 0 for that to trigger.
>
> So what would the right comparison be? Should it be for AR5416 v1.0 ?
> Or any AR5416 revision?
>
> Thanks,
>
>
>
> Adrian
> _______________________________________________
> ath9k-devel mailing list
> ath9k-devel at lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>
next prev parent reply other threads:[~2011-01-31 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 9:46 [ath9k-devel] AR5416 calibration / chainmask configuration bug? Adrian Chadd
2011-01-31 12:53 ` Mohammed Shafi [this message]
2011-02-01 3:49 ` Adrian Chadd
2011-02-01 12:13 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimRdX7Ac4ajHtCq3WzJpevAXNSu3sCmuRGau-+o@mail.gmail.com \
--to=shafi.wireless@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.