From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshiaki Tamura Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode. Date: Sat, 29 Jan 2011 00:31:48 +0900 Message-ID: References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4D42BD7D.8020004@redhat.com> <4D42D601.9010905@redhat.com> <4D42DC5E.8060203@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com To: Paolo Bonzini Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:64196 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169Ab1A1Pbt convert rfc822-to-8bit (ORCPT ); Fri, 28 Jan 2011 10:31:49 -0500 Received: by eye27 with SMTP id 27so1584690eye.19 for ; Fri, 28 Jan 2011 07:31:48 -0800 (PST) In-Reply-To: <4D42DC5E.8060203@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2011/1/29 Paolo Bonzini : > On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote: >> >> Having a scheme like "kemari:tcp:host:port" looks quite >> challenging to me. =A0We can of course add some quick hacks for it, >> but adding a nice layered architecture should be more >> appropriate. =A0Similar to protocols and formats in block layer? >> At the same time, I want to avoid anything over engineered. > > I was simply thinking of > > =A0 if (strstart (uri, "kemari:", &p)) { > =A0 =A0 =A0 ft_mode =3D FT_INIT; > =A0 =A0 =A0 uri =3D p; > =A0 } > > :) That's the hack I was imaging :) Maybe this is just an issue of preference, but I'm not sure adding "kemari:" to be intuitive. If there were similar extensions having the same problem, I would have agreed quickly. I originally didn't have this idea, but simply adding -kemari separate from -incoming isn't enough? Thanks, Yoshi > I think the same could be done for outgoing migration instead of -k > actually. > > Paolo > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35882 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiqIg-0008Vr-Kp for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:31:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PiqIf-0004P7-Iy for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:31:50 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:45306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PiqIf-0004P3-DM for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:31:49 -0500 Received: by wwi18 with SMTP id 18so3233097wwi.10 for ; Fri, 28 Jan 2011 07:31:48 -0800 (PST) MIME-Version: 1.0 Sender: tamura.yoshiaki@gmail.com In-Reply-To: <4D42DC5E.8060203@redhat.com> References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4D42BD7D.8020004@redhat.com> <4D42D601.9010905@redhat.com> <4D42DC5E.8060203@redhat.com> Date: Sat, 29 Jan 2011 00:31:48 +0900 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode. From: Yoshiaki Tamura Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com 2011/1/29 Paolo Bonzini : > On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote: >> >> Having a scheme like "kemari:tcp:host:port" looks quite >> challenging to me. =A0We can of course add some quick hacks for it, >> but adding a nice layered architecture should be more >> appropriate. =A0Similar to protocols and formats in block layer? >> At the same time, I want to avoid anything over engineered. > > I was simply thinking of > > =A0 if (strstart (uri, "kemari:", &p)) { > =A0 =A0 =A0 ft_mode =3D FT_INIT; > =A0 =A0 =A0 uri =3D p; > =A0 } > > :) That's the hack I was imaging :) Maybe this is just an issue of preference, but I'm not sure adding "kemari:" to be intuitive. If there were similar extensions having the same problem, I would have agreed quickly. I originally didn't have this idea, but simply adding -kemari separate from -incoming isn't enough? Thanks, Yoshi > I think the same could be done for outgoing migration instead of -k > actually. > > Paolo > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html >