From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757250Ab1CIPQK (ORCPT ); Wed, 9 Mar 2011 10:16:10 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:52239 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757097Ab1CIPQI convert rfc822-to-8bit (ORCPT ); Wed, 9 Mar 2011 10:16:08 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=P6VWCclgZ4J7iq5qsPa0Jmtj8crrlMvdC5tJdqFolXhIfyrgW8tirqYhQiPtBa+JT+ yCMcHaOdTX9NaqsVPIpH8Na65iIHFZJI0ZFMtRfS9WB0jnbvupMe98P7zXardL3Lo2US XFCo1b87kDJAyW2cZdmF8uY09cxcLHywUe1rE= MIME-Version: 1.0 In-Reply-To: <20110302180259.109909335@chello.nl> References: <20110302175928.022902359@chello.nl> <20110302180259.109909335@chello.nl> Date: Wed, 9 Mar 2011 15:16:07 +0000 X-Google-Sender-Auth: GgeUI2PwzGYwD4LyD9PoXMdBDt8 Message-ID: Subject: Re: [RFC][PATCH 4/6] arm, mm: Convert arm to generic tlb From: Catalin Marinas To: Peter Zijlstra Cc: Andrea Arcangeli , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Russell King , Chris Metcalf , Martin Schwidefsky Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 2 March 2011 17:59, Peter Zijlstra wrote: > --- linux-2.6.orig/arch/arm/include/asm/tlb.h > +++ linux-2.6/arch/arm/include/asm/tlb.h [...] > +__pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) >  { >        pgtable_page_dtor(pte); > -       tlb_add_flush(tlb, addr); >        tlb_remove_page(tlb, pte); >  } I think we still need a tlb_track_range() call here. On the path to pte_free_tlb() (for example shift_arg_pages ... free_pte_range) there doesn't seem to be any code setting the tlb->start/end range. Did I miss anything? Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 5E46F8D0039 for ; Wed, 9 Mar 2011 10:16:09 -0500 (EST) Received: by yxt33 with SMTP id 33so352738yxt.14 for ; Wed, 09 Mar 2011 07:16:07 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20110302180259.109909335@chello.nl> References: <20110302175928.022902359@chello.nl> <20110302180259.109909335@chello.nl> Date: Wed, 9 Mar 2011 15:16:07 +0000 Message-ID: Subject: Re: [RFC][PATCH 4/6] arm, mm: Convert arm to generic tlb From: Catalin Marinas Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: Andrea Arcangeli , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Russell King , Chris Metcalf , Martin Schwidefsky Hi Peter, On 2 March 2011 17:59, Peter Zijlstra wrote: > --- linux-2.6.orig/arch/arm/include/asm/tlb.h > +++ linux-2.6/arch/arm/include/asm/tlb.h [...] > +__pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr= ) > =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0pgtable_page_dtor(pte); > - =C2=A0 =C2=A0 =C2=A0 tlb_add_flush(tlb, addr); > =C2=A0 =C2=A0 =C2=A0 =C2=A0tlb_remove_page(tlb, pte); > =C2=A0} I think we still need a tlb_track_range() call here. On the path to pte_free_tlb() (for example shift_arg_pages ... free_pte_range) there doesn't seem to be any code setting the tlb->start/end range. Did I miss anything? Thanks. --=20 Catalin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org