From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yx0-f170.google.com (mail-yx0-f170.google.com [209.85.213.170]) by ozlabs.org (Postfix) with ESMTP id DCB62B6EFE for ; Tue, 14 Sep 2010 00:10:47 +1000 (EST) Received: by yxt33 with SMTP id 33so2056376yxt.15 for ; Mon, 13 Sep 2010 07:10:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <3850A844E6A3854C827AC5C0BEC7B60A1FC158@zch01exm23.fsl.freescale.net> References: <1284027632-32573-1-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-2-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-3-git-send-email-tie-fei.zang@freescale.com> <20100909114153.GB6622@oksana.dev.rtsoft.ru> <3850A844E6A3854C827AC5C0BEC7B60A1FC158@zch01exm23.fsl.freescale.net> From: Timur Tabi Date: Mon, 13 Sep 2010 09:10:15 -0500 Message-ID: Subject: Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode To: Zang Roy-R61911 Content-Type: text/plain; charset=ISO-8859-1 Cc: Wood Scott-B07421 , dedekind1@gmail.com, Lan Chunhe-B25806 , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, akpm@linux-foundation.org, dwmw2@infradead.org, Gala Kumar-B11780 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Sep 13, 2010 at 2:30 AM, Zang Roy-R61911 wrote: > What is the different for unsigned int and u32? I think they are same. Roy, please don't ever write code that assumes that sizeof(int) == 4. There's a reason why we have unsized integer types (like int, long, and short) and sized integer types (like u8, u16, u32). If you want an integer of a specific size, you should use a sized integer type. -- Timur Tabi Linux kernel developer at Freescale From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-gw0-f49.google.com ([74.125.83.49]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Ov9kA-00035c-At for linux-mtd@lists.infradead.org; Mon, 13 Sep 2010 14:10:50 +0000 Received: by gwj21 with SMTP id 21so2502187gwj.36 for ; Mon, 13 Sep 2010 07:10:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <3850A844E6A3854C827AC5C0BEC7B60A1FC158@zch01exm23.fsl.freescale.net> References: <1284027632-32573-1-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-2-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-3-git-send-email-tie-fei.zang@freescale.com> <20100909114153.GB6622@oksana.dev.rtsoft.ru> <3850A844E6A3854C827AC5C0BEC7B60A1FC158@zch01exm23.fsl.freescale.net> From: Timur Tabi Date: Mon, 13 Sep 2010 09:10:15 -0500 Message-ID: Subject: Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode To: Zang Roy-R61911 Content-Type: text/plain; charset=ISO-8859-1 Cc: Wood Scott-B07421 , dedekind1@gmail.com, Lan Chunhe-B25806 , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Anton Vorontsov , akpm@linux-foundation.org, dwmw2@infradead.org, Gala Kumar-B11780 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Sep 13, 2010 at 2:30 AM, Zang Roy-R61911 wrote: > What is the different for unsigned int and u32? I think they are same. Roy, please don't ever write code that assumes that sizeof(int) == 4. There's a reason why we have unsized integer types (like int, long, and short) and sized integer types (like u8, u16, u32). If you want an integer of a specific size, you should use a sized integer type. -- Timur Tabi Linux kernel developer at Freescale