From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761210Ab0J0NP5 (ORCPT ); Wed, 27 Oct 2010 09:15:57 -0400 Received: from mail-qy0-f181.google.com ([209.85.216.181]:63035 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756548Ab0J0NPz convert rfc822-to-8bit (ORCPT ); Wed, 27 Oct 2010 09:15:55 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=d0UBSx8xcA/N1vVGKL1IpcDVLXfBbAwfXB9hk1Kui0LOtt4yrnteGBFgMFjKeAfElS YN8n9uYCQF4HNuJDCn9vR0su2j6qdkQVpegvzujmOS+kdoNLkdzU31PE6T08Td2mPa+S ulWi7KBbI6nud5rG2BOHQn2bkfSYXgwRgu7JE= MIME-Version: 1.0 In-Reply-To: <20101026132649.623461f9@endymion.delvare> References: <4CC645A1.5010509@dsn.okisemi.com> <20101026102048.316d0c04@endymion.delvare> <001a01cb74ec$e3eb3ea0$66f8800a@maildom.okisemi.com> <20101026111322.738b0b14@endymion.delvare> <001c01cb74f2$d3dd8990$66f8800a@maildom.okisemi.com> <20101026132649.623461f9@endymion.delvare> Date: Wed, 27 Oct 2010 09:15:53 -0400 Message-ID: Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 From: Linus Walleij To: Jean Delvare Cc: Tomoya MORINAGA , Samuel Ortiz , Wolfram Sang , Ralf Baechle , linux-i2c@vger.kernel.org, LKML , Ben Dooks , srinidhi kasagar , Tomoya MORINAGA , Wang Qi , Wang Yong Y , kok.howg.ewe@intel.com, joel.clark@intel.com, andrew.chih.howe.khor@intel.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2010/10/26 Jean Delvare : > On Tue, 26 Oct 2010 18:47:37 +0900, Tomoya MORINAGA wrote: >> Must we get Intel's signature ? >> We have already got the following. Isn't  this enough ? >> > Reviewed-by: Linus Walleij >> >> Though I haven't heard like the requirement, >> if Intel's signature is mandatory, I will request to Intel. > > It's not mandatory, but the time Ben and myself have to review new > drivers is scarce, so it's in your own interest to have the code > reviewed by people with more time and more interest in the specific > hardware. I agree. My Reviewed-by is mainly about the code structure, a few antipatterns were removed and it looks nice to me now. We indeed need someone who knows the hardware to look at this. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 Date: Wed, 27 Oct 2010 09:15:53 -0400 Message-ID: References: <4CC645A1.5010509@dsn.okisemi.com> <20101026102048.316d0c04@endymion.delvare> <001a01cb74ec$e3eb3ea0$66f8800a@maildom.okisemi.com> <20101026111322.738b0b14@endymion.delvare> <001c01cb74f2$d3dd8990$66f8800a@maildom.okisemi.com> <20101026132649.623461f9@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20101026132649.623461f9-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: Tomoya MORINAGA , Samuel Ortiz , Wolfram Sang , Ralf Baechle , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , Ben Dooks , srinidhi kasagar , Tomoya MORINAGA , Wang Qi , Wang Yong Y , kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-i2c@vger.kernel.org 2010/10/26 Jean Delvare : > On Tue, 26 Oct 2010 18:47:37 +0900, Tomoya MORINAGA wrote: >> Must we get Intel's signature ? >> We have already got the following. Isn't =A0this enough ? >> > Reviewed-by: Linus Walleij >> >> Though I haven't heard like the requirement, >> if Intel's signature is mandatory, I will request to Intel. > > It's not mandatory, but the time Ben and myself have to review new > drivers is scarce, so it's in your own interest to have the code > reviewed by people with more time and more interest in the specific > hardware. I agree. My Reviewed-by is mainly about the code structure, a few antipatterns were removed and it looks nice to me now. We indeed need someone who knows the hardware to look at this. Yours, Linus Walleij