From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144Ab0FNT5M (ORCPT ); Mon, 14 Jun 2010 15:57:12 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:50136 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100Ab0FNT5J convert rfc822-to-8bit (ORCPT ); Mon, 14 Jun 2010 15:57:09 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Atbyj8hc+LTMWrQjCFDQ6ZVyl+eZFigz2NpAsmlon2+c1ObfjrLwyVBKb0I59+YEhF YUZSSAaDsx4D2H/LdyL1iv79/YrX7oI2CZrs4zHMa/lk8pdHZiq5UeNJ9Qi5PA01xZQk OCQ3ZrmP4o2aWoXLmKw5H/f+BR94pBzccyCxQ= MIME-Version: 1.0 In-Reply-To: <201006142103.54616.rjw@sisk.pl> References: <201006141653.03879.rjw@sisk.pl> <201006142103.54616.rjw@sisk.pl> Date: Mon, 14 Jun 2010 15:57:07 -0400 Message-ID: Subject: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300 From: Alex Deucher To: "Rafael J. Wysocki" Cc: Dave Airlie , Linus Torvalds , Andrew Morton , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, dri-devel Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2010 at 3:03 PM, Rafael J. Wysocki wrote: > On Monday, June 14, 2010, Alex Deucher wrote: >> On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: >> > Alex, Dave, >> > >> > I'm afraid hibernation is broken on all machines using radeon/KMS with r300 >> > after commit ce8f53709bf440100cb9d31b1303291551cf517f >> > (drm/radeon/kms/pm: rework power management).  At least, I'm able to reproduce >> > the symptom, which is that the machine hangs hard around the point where an >> > image is created (probably during the device thaw phase), on two different >> > boxes with r300 (the output of lspci from one of them is attached for >> > reference, the other one is HP nx6325). >> > >> > Suspend to RAM appears to work fine at least on one of the affected boxes. >> > >> > Unfortunately, the commit above changes a lot of code and it's not too easy to >> > figure out what's wrong with it and I didn't have the time to look more into >> > details of this failure.  However, it looks like you use .suspend() and >> > .resume() callbacks as .freeze() and .thaw() which may not be 100% correct >> > (in fact it looks like the "legacy" PCI suspend/resume is used, which is not >> > recommended any more). >> > >> >> Does it work any better after Dave's last drm pull request? > > Nope.  The symptom is slightly different, though, because now it hangs after > turning off the screen. > >> With the latest changes, pm should not be a factor unless it's explicitly >> enabled via sysfs. > > Well, I guess the first pm patch changed more than just pm, then. Does this patch help? http://lists.freedesktop.org/archives/dri-devel/2010-June/001314.html Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300 Date: Mon, 14 Jun 2010 15:57:07 -0400 Message-ID: References: <201006141653.03879.rjw@sisk.pl> <201006142103.54616.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com [209.85.161.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B32D9E80C for ; Mon, 14 Jun 2010 12:57:08 -0700 (PDT) Received: by fxm14 with SMTP id 14so2452250fxm.36 for ; Mon, 14 Jun 2010 12:57:07 -0700 (PDT) In-Reply-To: <201006142103.54616.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, dri-devel , Dave Airlie , Andrew Morton , Linus Torvalds , linux-pm@lists.linux-foundation.org List-Id: dri-devel@lists.freedesktop.org On Mon, Jun 14, 2010 at 3:03 PM, Rafael J. Wysocki wrote: > On Monday, June 14, 2010, Alex Deucher wrote: >> On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: >> > Alex, Dave, >> > >> > I'm afraid hibernation is broken on all machines using radeon/KMS with= r300 >> > after commit ce8f53709bf440100cb9d31b1303291551cf517f >> > (drm/radeon/kms/pm: rework power management). =A0At least, I'm able to= reproduce >> > the symptom, which is that the machine hangs hard around the point whe= re an >> > image is created (probably during the device thaw phase), on two diffe= rent >> > boxes with r300 (the output of lspci from one of them is attached for >> > reference, the other one is HP nx6325). >> > >> > Suspend to RAM appears to work fine at least on one of the affected bo= xes. >> > >> > Unfortunately, the commit above changes a lot of code and it's not too= easy to >> > figure out what's wrong with it and I didn't have the time to look mor= e into >> > details of this failure. =A0However, it looks like you use .suspend() = and >> > .resume() callbacks as .freeze() and .thaw() which may not be 100% cor= rect >> > (in fact it looks like the "legacy" PCI suspend/resume is used, which = is not >> > recommended any more). >> > >> >> Does it work any better after Dave's last drm pull request? > > Nope. =A0The symptom is slightly different, though, because now it hangs = after > turning off the screen. > >> With the latest changes, pm should not be a factor unless it's explicitly >> enabled via sysfs. > > Well, I guess the first pm patch changed more than just pm, then. Does this patch help? http://lists.freedesktop.org/archives/dri-devel/2010-June/001314.html Alex