All of lore.kernel.org
 help / color / mirror / Atom feed
From: trapDoor <trapdoor6@gmail.com>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Michal Marek <mmarek@suse.cz>,
	LKML <linux-kernel@vger.kernel.org>,
	"Justin P. Mattock" <justinmattock@gmail.com>,
	trivial@kernel.org
Subject: Re: Small typo in kernel [current source from git] .config option
Date: Thu, 29 Jul 2010 07:20:19 +0100	[thread overview]
Message-ID: <AANLkTimhKT=mmL7Q5D1z2mzu7wt25_NzA328Tp3T8y0v@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikpm8St4egQ7PpExzKkSTff5VZN-dKjAAA0nwoN@mail.gmail.com>

Hello,

On Thu, Jul 29, 2010 at 6:04 AM, Nir Tzachar <nir.tzachar@gmail.com> wrote:
> Hello.
>
> On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
>> On Wed, Jul 28, 2010 at 05:41:47PM +0200, Michal Marek wrote:
>>> (adding Nir, who wrote nconfig, to CC).
>>>
>>> On 28.7.2010 14:17, trapDoor wrote:
>>> > On Wed, Jul 28, 2010 at 12:02 PM, Michal Marek <mmarek@suse.cz> wrote:
>>> >> respectively). Unfortunatelly, there doesn't seem to be a way to
>>> >> highlight single letters in an ncurses menu, hence the strange
>>> >> cApitalization :(.
>>> >
>>> > I wonder how is this resolved in other console applications such as
>>> > Midnight Commander. Does it have its own implementation for
>>> > highlighting characters (it uses coloured mnemonics e.g. in menus) or
>>> > it's based on some common Linux/Unix library which perhaps could be
>>> > used for the nconfig as well?
>>>
>>> The problem is that nconfig uses the higher-level ncurses libraries
>>> libmenu and libpanel, which make some things easier, but aren't as
>>> flexible as using ncurses directly. Patches are welcome of course :-).
>
> The problem does arise from the use of libmenue, which gives you no
> control over the rendering of menue items. You can not specify any
> attributes for specific menu item's letters.
>
>> The capitilazing is the main reason why I have
>> not recommended nconfig to be default.
>>
>> And I doubt the shortcut letters are used that often.
>> One idea could be to drop the shortcut for the individual menus.
>
> I almost never use them and removing them will have the benefit of
> cleaning the code.
>

Neither do I. And I don't know anyone who would find them very useful.
Anyway, if you compile kernel regularly, especially from git, you
usually keep the same .config from previous compilations, and just run
make oldconfig rather than any of the graphical tools. Unless you want
to do some major changes. But even then I don't think many people
would care about key shortcuts.

Only if they were going to be kept in nconfig I'd say that fixing the
capitalisation somehow would be a good thing to do. But if you are
going to remove them and thus make the fix possible and the code
cleaner - that suits me. I will still prefer the simple and clean
nconfig's interface over menuconfig with mnemonics.

> A different approach may be to reimplement libmenu's logic (recreating
> the old lxdialog code), but avoiding this was part of the reason for
> writing nconfig....
>
> In any way, I am happy people are starting to use nconfig.
> Cheers.
>

-- 
Thanks,
trapDoor

  reply	other threads:[~2010-07-29  6:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 14:46 Small typo in kernel [current source from git] .config option trapDoor
2010-07-27 15:50 ` Justin P. Mattock
2010-07-27 16:35   ` trapDoor
2010-07-27 16:45     ` Justin P. Mattock
2010-07-27 16:55 ` Sam Ravnborg
2010-07-27 17:12   ` trapDoor
2010-07-28 11:02     ` Michal Marek
2010-07-28 12:17       ` trapDoor
2010-07-28 15:41         ` Michal Marek
2010-07-28 18:55           ` Sam Ravnborg
2010-07-29  5:04             ` Nir Tzachar
2010-07-29  6:20               ` trapDoor [this message]
2010-07-29  8:05                 ` Michal Marek
2010-07-29 10:33                   ` Nir Tzachar
2010-07-29 14:19                     ` Randy Dunlap
2010-07-29 19:50                       ` Nir Tzachar
2010-08-01  7:20                         ` [PATCH] nconfig: add search support nir.tzachar
2010-08-01  7:20                           ` nir.tzachar
2010-08-01  9:28                           ` Sam Ravnborg
2010-08-01 10:21                             ` Nir Tzachar
2010-08-01 11:49                               ` Sam Ravnborg
2010-08-02 16:32                           ` Randy Dunlap
2010-08-03  4:37                             ` Nir Tzachar
2010-08-02 21:22                           ` rdunlap
2010-08-02 21:22                             ` rdunlap
2010-08-03  4:41                             ` Nir Tzachar
2010-08-03 12:28                               ` nir.tzachar
2010-08-03 12:28                                 ` nir.tzachar
2010-08-05 17:04                                 ` Randy Dunlap
2010-08-05 18:13                                   ` Nir Tzachar
2010-08-05 18:19                                     ` Randy Dunlap
2010-08-06 12:41                                       ` Nir Tzachar
2010-08-06 13:54                                     ` Sam Ravnborg
2010-08-06 19:22                                       ` Nir Tzachar
2010-08-06 14:09                                   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimhKT=mmL7Q5D1z2mzu7wt25_NzA328Tp3T8y0v@mail.gmail.com' \
    --to=trapdoor6@gmail.com \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nir.tzachar@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.