From: Linus Torvalds <torvalds@linux-foundation.org>
To: Pekka Enberg <penberg@kernel.org>, Eric Paris <eparis@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: Thomas Meyer <thomas@m3y3r.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.de>
Subject: Re: 2.6.36: Sound stop working
Date: Thu, 12 Aug 2010 14:01:50 -0700 [thread overview]
Message-ID: <AANLkTimr_S3rtg50wOh+H4yybn_U6Ru3=rbt5FjYWpD3@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=Sh=4mmV2B_VsQw-1+jHzf2jWZsYQkJmqWwms+@mail.gmail.com>
On Thu, Aug 12, 2010 at 1:20 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> So I suspect it's not sound that is broken at all, but pulseaudio that
> got broken by the fanotify changes.
Confirmed. That broken commit 3bcf3860a4ff9bb doesn't even boot for me
(looks like a stack smash recursion), and the commit to "fix" it
(c1e5c954020e12) is really too ugly to live.
I think we need to totally undo the whole "struct file" thing, and
just admit that it was a mistake. The code really wants a "struct
path", and using a struct file screws up all the refcounting and is
just not right.
The fact that dentry_open() may have some problem needs to be fixed
-there- rather than make the callers do crazy things that they don't
want to do and can't do sanely.
Linus
next prev parent reply other threads:[~2010-08-12 21:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 20:00 2.6.36: Sound stop working Thomas Meyer
2010-08-12 20:10 ` Pekka Enberg
2010-08-12 20:20 ` Linus Torvalds
2010-08-12 21:01 ` Linus Torvalds [this message]
2010-08-12 20:26 ` Takashi Iwai
2010-08-12 21:01 ` Jiri Slaby
2010-08-12 21:14 ` Maxim Levitsky
2010-08-12 21:17 ` Takashi Iwai
2010-08-12 21:41 ` Linus Torvalds
2010-08-12 21:50 ` Linus Torvalds
2010-08-12 21:52 ` Al Viro
2010-08-12 22:19 ` Linus Torvalds
2010-08-13 1:53 ` Eric Paris
2010-08-13 7:50 ` Jiri Slaby
2010-08-12 22:07 ` Takashi Iwai
2010-08-12 21:18 ` Linus Torvalds
2010-08-12 21:24 ` Jiri Slaby
2010-08-12 21:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimr_S3rtg50wOh+H4yybn_U6Ru3=rbt5FjYWpD3@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=thomas@m3y3r.de \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.