All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [DRM] BUG: sleeping function called from invalid context, drm_lastclose
Date: Wed, 11 Aug 2010 18:50:45 +1000	[thread overview]
Message-ID: <AANLkTimx0No2RgS8EdZCz=X8urJ8u4hVEVH5c1mcz_CW__23878.8457973444$1281516682$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <20100811084828.GA5709@nb-core2.darkstar.lan>

On Wed, Aug 11, 2010 at 6:48 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
> Hi Arnd,
> this commit:
>
> commit 58374713c9dfb4d231f8c56cac089f6fbdedc2ec
> Author: Arnd Bergmann <arnd@arndb.de>
> Date:   Sat Jul 10 23:51:39 2010 +0200
>
>    drm: kill BKL from common code
>
>
> moved the call to (inside drm_release) drm_lastclose inside dev->count_lock
> spinlock.
> drm_lastclose however takes dev->struct_mutex (now inside an atomic
> context):

I have a patch from Chris Wilson that I need to push to fix this,
basically reducing the spin lock coverage,
and relying on the global mutex to handle the open race.

Dave.

>
> BUG: sleeping function called from invalid context at /home/kronos/src/linux-2.6.git/kernel/mutex.c:94
> in_atomic(): 1, irqs_disabled(): 0, pid: 3331, name: Xorg
> Pid: 3331, comm: Xorg Not tainted 2.6.35-06113-gf6cec0a #272
> Call Trace:
>  [<ffffffff8102770e>] __might_sleep+0xf8/0xfa
>  [<ffffffff8127cf18>] mutex_lock+0x1f/0x3e
>  [<ffffffffa052d1c1>] drm_lastclose+0x92/0x2ad [drm]
>  [<ffffffffa052dbc7>] drm_release+0x5ca/0x60d [drm]
>  [<ffffffff810b118f>] fput+0x130/0x1f7
>  [<ffffffff810ae77d>] filp_close+0x63/0x6d
>  [<ffffffff810ae82f>] sys_close+0xa8/0xe2
>  [<ffffffff8100296b>] system_call_fastpath+0x16/0x1b
>
>
> Luca
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
--

  parent reply	other threads:[~2010-08-11  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11  8:48 [DRM] BUG: sleeping function called from invalid context, drm_lastclose Luca Tettamanti
2010-08-11  8:50 ` Dave Airlie
2010-08-11 12:49   ` Arnd Bergmann
2010-08-11 12:49   ` Arnd Bergmann
2010-08-11 14:17   ` Luca Tettamanti
2010-08-11 14:17     ` Luca Tettamanti
2010-08-11  8:50 ` Dave Airlie [this message]
2010-08-11  8:48 Luca Tettamanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimx0No2RgS8EdZCz=X8urJ8u4hVEVH5c1mcz_CW__23878.8457973444$1281516682$gmane$org@mail.gmail.com' \
    --to=airlied@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.