From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bw0-f48.google.com (mail-bw0-f48.google.com [209.85.214.48]) by mx1.pokylinux.org (Postfix) with ESMTP id 85DA34C80B6E for ; Wed, 26 Jan 2011 11:50:32 -0600 (CST) Authentication-Results: mx1.pokylinux.org; dkim=pass (1024-bit key; insecure key) header.i=@gmail.com; x-dkim-adsp=none (insecure policy) Received: by bwz8 with SMTP id 8so1689888bwz.35 for ; Wed, 26 Jan 2011 09:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=7LIgEXVPC8sJM3Z5m3iGvhdthgbh3AR1Dp3oo/HpAt8=; b=PGVuh4Maj6Th3/uXibxOQyrdnjlFkOL62UFXDT47tBMfEPWKsF9emspBaDUOo1pFRs uHMfHXLET+F2i0k3kPxdnjni8pBab86BsSEA2bSxjgel4YVgLMASi0zkYHKYHKhb7RDb BcsULfFUyZvG6jXOGvqt67m1jlhKXMrXufBBU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=IMuH8qmtJuKwGZ+Cuqlde/eZESQBb460/82cKZg9we87n0LkBNYSGMRy0lYwbBcvrM JYiV2qIR3lBMY4tZa+5HAUzxfwPlWNt1EbT02qhEyCnFgfJEoS/2qfqCP1k34vYzMe/E icS6BqqFr3HQs3fqD2eLyvf8x+zGZaosW48hY= MIME-Version: 1.0 Received: by 10.103.241.16 with SMTP id t16mr3739165mur.23.1296063677956; Wed, 26 Jan 2011 09:41:17 -0800 (PST) Sender: aalonso00@gmail.com Received: by 10.103.163.8 with HTTP; Wed, 26 Jan 2011 09:41:17 -0800 (PST) In-Reply-To: <4D3F42AB.9000002@linux.intel.com> References: <1295989756-7967-1-git-send-email-aalonso@secretlab.ca> <4D3F42AB.9000002@linux.intel.com> Date: Wed, 26 Jan 2011 11:41:17 -0600 X-Google-Sender-Auth: HRgkK8NjqVgb_T339q3qZiMTgvI Message-ID: From: Adrian Alonso To: Darren Hart Cc: Josh Lock , poky@yoctoproject.org Subject: Re: [PATCH 05/25][v2] u-boot: disable -Os option not supported by gcc X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2011 17:50:36 -0000 Content-Type: multipart/alternative; boundary=001636b43120221d22049ac3571b --001636b43120221d22049ac3571b Content-Type: text/plain; charset=ISO-8859-1 Got me, Yep the OPTFLAGS was not been set in u-boot. I end up overriding EXTRA_OEMAKE to set OPTFLAGS=-O2 Powerpc targets only builds with this option and is related to gcc bugs described in previous treads. In queue should patch v3 Regards On Tue, Jan 25, 2011 at 3:37 PM, Darren Hart wrote: > On 01/25/2011 01:09 PM, Adrian Alonso wrote: > >> * Disable -Os optspace option not supported by gcc >> * v2 use OPTFLAGS variable, remove meke file patch >> * Bump PR >> >> Signed-off-by: Adrian Alonso >> --- >> recipes-bsp/uboot/u-boot-xilinx_git.bb | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb b/recipes-bsp/uboot/ >> u-boot-xilinx_git.bb >> index 50d99e3..499ce0b 100644 >> --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb >> +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb >> @@ -1,9 +1,11 @@ >> require ../meta/recipes-bsp/uboot/u-boot.inc >> -PR = "r2" >> +PR = "r3" >> >> +OPTFLAGS="" >> > > Have you tested this build? Looking at the Makefile, it doesn't do a > conditional assignment, so I would expect OPTFLAGS set here to be ignored. > This is why I added it to EXTRA_OEMAKE, which overrides anything in the > Makefil, regardless of how it is assigned. At least, that was my > understanding of the mechanism. > > EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS=''" > > > Josh, I think you may had something to do with my education in this area - > can you comment? Am I all wet here? > > -- > Darren > > > BRANCH="master" >> TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98" >> -SRC_URI = "git:// >> git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git >> " >> +SRC_URI = "git:// >> git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git\ >> + " >> SRCREV = "${TAG}" >> >> inherit xilinx-boot >> > > > -- > Darren Hart > Intel Open Source Technology Center > Yocto Project - Linux Kernel > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky > --001636b43120221d22049ac3571b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Got me,

Yep the OPTFLAGS was not been set in u-boot.
I end up overriding=A0EXTRA_OEMAKE to set OPTFLAGS=3D-O2
Pow= erpc targets only builds with this option and is related to gcc bugs
described in previous treads.

In queue should= patch v3

Regards

On Tue, Jan 25, 2011 at 3:37 PM, Darren Hart <dvhart@linux.intel.com> w= rote:
On 01/25/2011 01:09 PM, A= drian Alonso wrote:
* Disable -Os optspace option not supported by gcc
* v2 use OPTFLAGS variable, remove meke file patch
* Bump PR

Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
---
=A0recipes-bsp/uboot/u-boot-xilinx_git.bb | =A0 =A06 ++++--
=A01 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb b/recipes-bsp/uboot/u-boot-xilinx_git.bb
index 50d99e3..499ce0b 100644
--- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
+++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
@@ -1,9 +1,11 @@
=A0require ../meta/recipes-bsp/uboot/u-boot.inc
-PR =3D "r2"
+PR =3D "r3"

+OPTFLAGS=3D""

Have you tested this build? Looking at the Makefile, it doesn't do a co= nditional assignment, so I would expect OPTFLAGS set here to be ignored. Th= is is why I added it to EXTRA_OEMAKE, which overrides anything in the Makef= il, regardless of how it is assigned. At least, that was my understanding o= f the mechanism.

EXTRA_OEMAKE =3D "CROSS_COMPILE=3D${TARGET_PREFIX} OPTFLAGS=3D'= 9;"


Josh, I think you may had something to do with my education in this area - = can you comment? Am I all wet here?

--
Darren


=A0BRANCH=3D"master"
=A0TAG=3D"e094f2479ea339d7f48b6826f06f0be4984d9a98"
-SRC_URI =3D "git://git.xilinx.com/u-bo= ot-xlnx.git;branch=3D${BRANCH};protocol=3Dgit"
+SRC_URI =3D "git://git.xilinx.com/u-bo= ot-xlnx.git;branch=3D${BRANCH};protocol=3Dgit \
+ =A0 =A0 =A0 =A0 =A0"
=A0SRCREV =3D "${TAG}"

=A0inherit xilinx-boot


--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
_______________________________________________
poky mailing list
poky@yoctoprojec= t.org
= https://lists.yoctoproject.org/listinfo/poky

--001636b43120221d22049ac3571b--