All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
	davem@davemloft.net, perfmon2-devel@lists.sf.net,
	eranian@gmail.com, robert.richter@amd.com,
	markus.t.metzger@intel.com
Subject: Re: [PATCH] perf_events: improve DS/BTS/PEBS buffer allocation
Date: Mon, 13 Sep 2010 17:20:12 +0200	[thread overview]
Message-ID: <AANLkTin35TXPcs9u3pLfo8QRUmGnftT1DPfswRUVEvJW@mail.gmail.com> (raw)
In-Reply-To: <1284391000.2275.338.camel@laptop>

On Mon, Sep 13, 2010 at 5:16 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2010-09-13 at 17:13 +0200, Stephane Eranian wrote:
>> > For now I think you can not do this. vmalloc'ed memory can't be safely
>> > accessed from NMIs in x86 because that might fault. And faults from NMIs
>> > are not supported. They cause very bad things: return from fault calls
>> > iret which reenables NMI, so NMI can nest but in the meantime there is
>> > only one NMI stack, so that gets quickly messed up.
>> >
>> What kind of faults are you talking about here? TLB faults?
>
> Page faults. vmalloc pte setup is lazy.
>
Is there a way to not do lazy?

I guess we could do alloc_pages_nodes() if we make sure the
buffer size can be expressed as a page order and not just a page size,
or we are willing to waste memory.

That is the case we the sizes you have chosen today. For DS, we
could round up to one page for now.

  reply	other threads:[~2010-09-13 15:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 14:55 [PATCH] perf_events: improve DS/BTS/PEBS buffer allocation Stephane Eranian
2010-09-13 15:08 ` Peter Zijlstra
2010-09-13 15:21   ` Stephane Eranian
2010-09-13 15:09 ` Frederic Weisbecker
2010-09-13 15:13   ` Stephane Eranian
2010-09-13 15:16     ` Peter Zijlstra
2010-09-13 15:20       ` Stephane Eranian [this message]
2010-09-13 15:24         ` Peter Zijlstra
2010-09-13 15:31           ` Stephane Eranian
2010-09-13 15:41             ` Peter Zijlstra
2010-09-13 15:51               ` Frederic Weisbecker
2010-09-13 15:55               ` Stephane Eranian
2010-09-13 17:35                 ` Peter Zijlstra
2010-09-13 18:40                   ` Stephane Eranian
2010-09-13 18:42                     ` Peter Zijlstra
2010-09-13 18:49                       ` Stephane Eranian
2010-09-13 18:57                         ` Peter Zijlstra
2010-09-13 19:12                           ` Stephane Eranian
2010-09-13 19:31                     ` Mathieu Desnoyers
2010-09-13 19:34                       ` Peter Zijlstra
2010-09-13 19:35                         ` Peter Zijlstra
2010-09-13 19:42                         ` Mathieu Desnoyers
2010-09-13 17:24               ` Stephane Eranian
2010-09-13 17:36                 ` Peter Zijlstra
2010-09-13 19:35 ` Andi Kleen
2010-09-13 19:49   ` Peter Zijlstra
2010-09-13 20:51     ` Andi Kleen
2010-09-13 20:57       ` [perfmon2] " Luck, Tony
2010-09-13 20:34   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTin35TXPcs9u3pLfo8QRUmGnftT1DPfswRUVEvJW@mail.gmail.com \
    --to=eranian@google.com \
    --cc=davem@davemloft.net \
    --cc=eranian@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@intel.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=peterz@infradead.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.