All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] plugins: hciops: remove scan disable on poweroff
       [not found] <1295973136-30908-1-git-send-email-pavan_savoy@sify.com>
@ 2011-01-25 16:33 ` Pavan Savoy
  2011-01-26 11:16   ` Johan Hedberg
  0 siblings, 1 reply; 6+ messages in thread
From: Pavan Savoy @ 2011-01-25 16:33 UTC (permalink / raw)
  To: linux-bluetooth

From: Pavan Savoy <pavan_savoy@sify.com>

remove sending of the scan disable command when the
device is being powered off.

Signed-off-by: Pavan Savoy <pavan_savoy@sify.com>
---
 plugins/hciops.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/plugins/hciops.c b/plugins/hciops.c
index 719ef01..59a15a0 100644
--- a/plugins/hciops.c
+++ b/plugins/hciops.c
@@ -335,14 +335,9 @@ static int hciops_set_pairable(int index,
gboolean pairable)
 static int hciops_power_off(int index)
 {
       struct dev_info *dev = &devs[index];
-       uint8_t mode = SCAN_DISABLED;

       DBG("hci%d", index);

-       if (hci_send_cmd(dev->sk, OGF_HOST_CTL,
-                                       OCF_WRITE_SCAN_ENABLE, 1, &mode) < 0)
-               return -errno;
-
       if (ioctl(dev->sk, HCIDEVDOWN, index) < 0 && errno != EALREADY)
               return -errno;

--
1.7.0.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] plugins: hciops: remove scan disable on poweroff
  2011-01-25 16:33 ` [PATCH] plugins: hciops: remove scan disable on poweroff Pavan Savoy
@ 2011-01-26 11:16   ` Johan Hedberg
  2011-01-26 11:26     ` Pavan Savoy
  0 siblings, 1 reply; 6+ messages in thread
From: Johan Hedberg @ 2011-01-26 11:16 UTC (permalink / raw)
  To: Pavan Savoy; +Cc: linux-bluetooth

Hi Pavan,

On Tue, Jan 25, 2011, Pavan Savoy wrote:
> From: Pavan Savoy <pavan_savoy@sify.com>
> 
> remove sending of the scan disable command when the
> device is being powered off.
> 
> Signed-off-by: Pavan Savoy <pavan_savoy@sify.com>
> ---
>  plugins/hciops.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)

The patch seems to be corrupted (looks like the whitespace is messed
up):

Applying: plugins: hciops: remove scan disable on poweroff
fatal: corrupt patch at line 10
Patch failed at 0001 plugins: hciops: remove scan disable on poweroff

Could you try re-sending it e.g. with git send-email?

Johan

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] plugins: hciops: remove scan disable on poweroff
  2011-01-26 11:16   ` Johan Hedberg
@ 2011-01-26 11:26     ` Pavan Savoy
  0 siblings, 0 replies; 6+ messages in thread
From: Pavan Savoy @ 2011-01-26 11:26 UTC (permalink / raw)
  To: Pavan Savoy, linux-bluetooth

On Wed, Jan 26, 2011 at 4:46 PM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> Hi Pavan,
>
> On Tue, Jan 25, 2011, Pavan Savoy wrote:
>> From: Pavan Savoy <pavan_savoy@sify.com>
>>
>> remove sending of the scan disable command when the
>> device is being powered off.
>>
>> Signed-off-by: Pavan Savoy <pavan_savoy@sify.com>
>> ---
>>  plugins/hciops.c |    5 -----
>>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> The patch seems to be corrupted (looks like the whitespace is messed
> up):
>
> Applying: plugins: hciops: remove scan disable on poweroff
> fatal: corrupt patch at line 10
> Patch failed at 0001 plugins: hciops: remove scan disable on poweroff
>
> Could you try re-sending it e.g. with git send-email?

Yes, have sent it now, may be it was corrupted because it was
forwarded from a mail which
got it via git send-email.
I wasn't registered to linux-bluetooth, with the mail ID with which i
have smtp ..

so I hope it's ok now..

> Johan
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] plugins: hciops: remove scan disable on poweroff
  2011-01-26 11:36 ` Johan Hedberg
@ 2011-01-26 12:39   ` Pavan Savoy
  0 siblings, 0 replies; 6+ messages in thread
From: Pavan Savoy @ 2011-01-26 12:39 UTC (permalink / raw)
  To: pavan.savoy, linux-bluetooth, Pavan Savoy

On Wed, Jan 26, 2011 at 5:06 PM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> Hi Pavan,
>
> On Wed, Jan 26, 2011, pavan.savoy@gmail.com wrote:
>> From: Pavan Savoy <pavan_savoy@sify.com>
>>
>> remove sending of the scan disable command when the
>> device is being powered off.
>>
>> Signed-off-by: Pavan Savoy <pavan_savoy@sify.com>
>> ---
>>  plugins/hciops.c |    5 -----
>>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> Pushed upstream after I added some extra info to the commit message and
> removed the signed-off-by line (since we don't use that in user space).

Thanks Johan..

> Johan
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] plugins: hciops: remove scan disable on poweroff
  2011-01-26 11:21 pavan.savoy
@ 2011-01-26 11:36 ` Johan Hedberg
  2011-01-26 12:39   ` Pavan Savoy
  0 siblings, 1 reply; 6+ messages in thread
From: Johan Hedberg @ 2011-01-26 11:36 UTC (permalink / raw)
  To: pavan.savoy; +Cc: linux-bluetooth, Pavan Savoy

Hi Pavan,

On Wed, Jan 26, 2011, pavan.savoy@gmail.com wrote:
> From: Pavan Savoy <pavan_savoy@sify.com>
> 
> remove sending of the scan disable command when the
> device is being powered off.
> 
> Signed-off-by: Pavan Savoy <pavan_savoy@sify.com>
> ---
>  plugins/hciops.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)

Pushed upstream after I added some extra info to the commit message and
removed the signed-off-by line (since we don't use that in user space).

Johan

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] plugins: hciops: remove scan disable on poweroff
@ 2011-01-26 11:21 pavan.savoy
  2011-01-26 11:36 ` Johan Hedberg
  0 siblings, 1 reply; 6+ messages in thread
From: pavan.savoy @ 2011-01-26 11:21 UTC (permalink / raw)
  To: linux-bluetooth, johan.hedberg; +Cc: Pavan Savoy

From: Pavan Savoy <pavan_savoy@sify.com>

remove sending of the scan disable command when the
device is being powered off.

Signed-off-by: Pavan Savoy <pavan_savoy@sify.com>
---
 plugins/hciops.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/plugins/hciops.c b/plugins/hciops.c
index 719ef01..59a15a0 100644
--- a/plugins/hciops.c
+++ b/plugins/hciops.c
@@ -335,14 +335,9 @@ static int hciops_set_pairable(int index, gboolean pairable)
 static int hciops_power_off(int index)
 {
 	struct dev_info *dev = &devs[index];
-	uint8_t mode = SCAN_DISABLED;
 
 	DBG("hci%d", index);
 
-	if (hci_send_cmd(dev->sk, OGF_HOST_CTL,
-					OCF_WRITE_SCAN_ENABLE, 1, &mode) < 0)
-		return -errno;
-
 	if (ioctl(dev->sk, HCIDEVDOWN, index) < 0 && errno != EALREADY)
 		return -errno;
 
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-26 12:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1295973136-30908-1-git-send-email-pavan_savoy@sify.com>
2011-01-25 16:33 ` [PATCH] plugins: hciops: remove scan disable on poweroff Pavan Savoy
2011-01-26 11:16   ` Johan Hedberg
2011-01-26 11:26     ` Pavan Savoy
2011-01-26 11:21 pavan.savoy
2011-01-26 11:36 ` Johan Hedberg
2011-01-26 12:39   ` Pavan Savoy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.