From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH v2 14/16] Intel net drivers: convert to ndo_fix_features
Date: Sun, 23 Jan 2011 23:06:32 -0800 [thread overview]
Message-ID: <AANLkTin8Q322ybP=kqGHHaVHynW9BvmECc7Sf+y460Xo@mail.gmail.com> (raw)
In-Reply-To: <28a1c0f6e1ab9a523ee1e947ca4a013fd5730539.1295734271.git.mirq-linux@rere.qmqm.pl>
2011/1/22 Michał Mirosław <mirq-linux@rere.qmqm.pl>:
> Private rx_csum flags are now duplicate of netdev->features & NETIF_F_RXCSUM.
> Removing this needs deeper surgery.
>
> Since ixgbevf doesn't change hardware state on RX csum enable/disable
> its reset is avoided.
>
> Things noticed:
> - e1000, e1000e and ixgb have RX csum disabled by default
> - HW VLAN acceleration probably can be toggled, but it's left as is
> - the resets on RX csum offload change can probably be avoided
> - there is A LOT of copy-and-pasted code here
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> drivers/net/e1000/e1000_ethtool.c | 69 ------------------------------------
> drivers/net/e1000/e1000_main.c | 30 +++++++++++++--
> drivers/net/e1000e/ethtool.c | 62 --------------------------------
> drivers/net/e1000e/netdev.c | 30 +++++++++++++--
> drivers/net/igb/igb_ethtool.c | 67 ----------------------------------
> drivers/net/igb/igb_main.c | 33 +++++++++++++----
> drivers/net/igbvf/ethtool.c | 57 -----------------------------
> drivers/net/igbvf/netdev.c | 25 ++++++++++---
> drivers/net/ixgb/ixgb.h | 2 +
> drivers/net/ixgb/ixgb_ethtool.c | 59 +------------------------------
> drivers/net/ixgb/ixgb_main.c | 31 ++++++++++++++--
> drivers/net/ixgbe/ixgbe_ethtool.c | 65 ---------------------------------
> drivers/net/ixgbe/ixgbe_main.c | 31 +++++++++++-----
> drivers/net/ixgbevf/ethtool.c | 46 ------------------------
> drivers/net/ixgbevf/ixgbevf_main.c | 26 +++++++++++---
> 15 files changed, 172 insertions(+), 461 deletions(-)
>
I have applied this patch for review and testing to my tree
I have also applied the 1-13 patches just for testing purposes, so
that we can adequately test the changes to the Intel Wired drivers
--
Cheers,
Jeff
next prev parent reply other threads:[~2011-01-24 7:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 22:14 [PATCH v2 00/16] net: Unified offload configuration Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 03/16] net: reduce and unify printk level in netdev_fix_features() Michał Mirosław
2011-01-22 23:12 ` Joe Perches
2011-01-22 23:40 ` Michał Mirosław
2011-01-23 12:44 ` [PATCH] " Michał Mirosław
2011-01-22 23:48 ` [PATCH v2 03/16] " Michał Mirosław
2011-01-24 23:45 ` David Miller
2011-01-22 22:14 ` [PATCH v2 01/16] net: Move check of checksum features to netdev_fix_features() Michał Mirosław
2011-01-24 23:29 ` David Miller
2011-01-22 22:14 ` [PATCH v2 02/16] net: change netdev->features to u32 Michał Mirosław
2011-01-23 10:35 ` Eric Dumazet
2011-01-23 12:44 ` [PATCH] " Michał Mirosław
2011-01-24 23:30 ` [PATCH v2 02/16] " David Miller
2011-01-25 11:07 ` Michał Mirosław
2011-01-25 20:37 ` David Miller
2011-01-22 22:14 ` [PATCH v2 08/16] loopback: convert to hw_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 12/16] jme: convert offload constraints to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 05/16] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 11/16] bonding: convert to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 06/16] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 10/16] vlan: convert VLAN devices to use ndo_fix_features() Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 09/16] bridge: convert br_features_recompute() to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 04/16] net: Introduce new feature setting ops Michał Mirosław
2011-01-24 23:51 ` David Miller
2011-01-25 1:26 ` Ben Hutchings
2011-01-22 22:14 ` [PATCH v2 07/16] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 13/16] virtio_net: convert to ndo_fix_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 15/16] veth: convert to hw_features Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 16/16] skge: " Michał Mirosław
2011-01-31 16:45 ` Stephen Hemminger
2011-01-31 21:53 ` Michał Mirosław
2011-01-31 22:40 ` Michał Mirosław
2011-01-31 23:08 ` Michał Mirosław
2011-01-22 22:14 ` [PATCH v2 14/16] Intel net drivers: convert to ndo_fix_features Michał Mirosław
2011-01-24 7:06 ` Jeff Kirsher [this message]
2011-01-26 9:47 ` Jeff Kirsher
2011-04-07 12:51 ` Michał Mirosław
2011-04-07 15:00 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTin8Q322ybP=kqGHHaVHynW9BvmECc7Sf+y460Xo@mail.gmail.com' \
--to=jeffrey.t.kirsher@intel.com \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.