From: Chad Talbott <ctalbott@google.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: Vivek Goyal <vgoyal@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Jeff Moyer <jmoyer@redhat.com>, Divyesh Shah <dpshah@google.com>,
Corrado Zoccolo <czoccolo@gmail.com>,
Nauman Rafique <nauman@google.com>,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchical scheduling support
Date: Mon, 30 Aug 2010 11:20:18 -0700 [thread overview]
Message-ID: <AANLkTinCW-U2aOUh7yHM3mBdKAdeGiY-MvbvowFe5p-j@mail.gmail.com> (raw)
In-Reply-To: <4C7B54C0.7080008@cn.fujitsu.com>
On Sun, Aug 29, 2010 at 11:50 PM, Gui Jianfeng
<guijianfeng@cn.fujitsu.com> wrote:
> o Each cfq group has its own group service tree.
> o Each cfq group contains a "group schedule entity" (gse) that
> schedules on parent cfq group's service tree.
> o Each cfq group contains a "queue schedule entity"(qse), it
> represents all cfqqs located on this cfq group. It schedules
> on this group's service tree. For the time being, root group
> qse's weight is 1000, and subgroup qse's weight is 500.
> o All gses and qse which belones to a same cfq group schedules
> on the same group service tree.
Overall, I like this approach. It's similar to what we are using with
earlier hierarchical patches. Can you improve the naming a little
bit? "qse" and "gse" look almost identical and breaks my brain.
Maybe "queue_entity" and "group_entity"? If entity is to much to
type, then "item"?
Chad
next prev parent reply other threads:[~2010-08-30 18:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 6:50 [RFC] [PATCH] cfq-iosched: add cfq group hierarchical scheduling support Gui Jianfeng
2010-08-30 18:20 ` Chad Talbott [this message]
2010-08-31 0:35 ` Gui Jianfeng
2010-08-30 20:36 ` Vivek Goyal
2010-08-31 0:29 ` Gui Jianfeng
2010-08-31 12:57 ` Vivek Goyal
2010-08-31 15:40 ` Nauman Rafique
2010-08-31 19:25 ` Vivek Goyal
2010-09-01 8:50 ` Gui Jianfeng
2010-09-01 15:49 ` Nauman Rafique
2010-09-01 17:10 ` Vivek Goyal
2010-09-01 17:15 ` Nauman Rafique
2010-09-01 17:21 ` Vivek Goyal
2010-09-02 0:30 ` Gui Jianfeng
2010-09-02 2:20 ` Vivek Goyal
2010-09-01 8:48 ` Gui Jianfeng
2010-09-01 9:02 ` KAMEZAWA Hiroyuki
2010-09-02 2:29 ` Vivek Goyal
2010-09-02 2:42 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinCW-U2aOUh7yHM3mBdKAdeGiY-MvbvowFe5p-j@mail.gmail.com \
--to=ctalbott@google.com \
--cc=axboe@kernel.dk \
--cc=czoccolo@gmail.com \
--cc=dpshah@google.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nauman@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.