From: Ohad Ben-Cohen <ohad@wizery.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Luciano Coelho <luciano.coelho@nokia.com>
Subject: Re: [PATCH] wl1271: sdio: claim host only when doing IO
Date: Tue, 14 Sep 2010 23:30:30 +0200 [thread overview]
Message-ID: <AANLkTinCyHrKxDYmdbWWXNRQ+zrHtnqLLDKQa-qp3OFV@mail.gmail.com> (raw)
In-Reply-To: <20100914203000.GF2484@tuxdriver.com>
On Tue, Sep 14, 2010 at 10:30 PM, John W. Linville
<linville@tuxdriver.com> wrote:
> drivers/net/wireless/wl12xx/wl1271_sdio.c: In function ‘wl1271_sdio_set_power’:
> drivers/net/wireless/wl12xx/wl1271_sdio.c:193: warning: ‘return’ with a value, in function returning void
> drivers/net/wireless/wl12xx/wl1271_sdio.c:195: warning: ‘return’ with a value, in function returning void
> drivers/net/wireless/wl12xx/wl1271_sdio.c:186: warning: unused variable ‘func’
Sorry, I wrote the original patch on my branch which already
propagates the error code from set_power.
> I'll fix these in a separate patch.
If you prefer I can submit a new one.
Thanks,
Ohad.
>
> John
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
>
next prev parent reply other threads:[~2010-09-14 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 1:24 [PATCH] wl1271: sdio: claim host only when doing IO Ohad Ben-Cohen
2010-09-08 18:00 ` Luciano Coelho
2010-09-14 20:30 ` John W. Linville
2010-09-14 20:30 ` [PATCH] wl1271: remove warnings in wl1271_sdio_set_power John W. Linville
2010-09-14 21:30 ` Ohad Ben-Cohen [this message]
2010-09-15 1:18 ` [PATCH] wl1271: sdio: claim host only when doing IO John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinCyHrKxDYmdbWWXNRQ+zrHtnqLLDKQa-qp3OFV@mail.gmail.com \
--to=ohad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.