From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Kristian_H=C3=B8gsberg?= Subject: Re: [PATCH 14/14] drm: kill agp indirection mess Date: Tue, 24 Aug 2010 11:05:04 -0400 Message-ID: References: <1282596816-10896-1-git-send-email-daniel.vetter@ffwll.ch> <1282596816-10896-15-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-bw0-f49.google.com (mail-bw0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 97DE39E733 for ; Tue, 24 Aug 2010 08:05:05 -0700 (PDT) Received: by bwz13 with SMTP id 13so6502125bwz.36 for ; Tue, 24 Aug 2010 08:05:04 -0700 (PDT) In-Reply-To: <1282596816-10896-15-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMjMsIDIwMTAgYXQgNDo1MyBQTSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBmZndsbC5jaD4gd3JvdGU6Cj4gVGhlcmUncyBubyBwb2ludCBpbiBqdW1waW5nIHRocm91 Z2ggdHdvIGluZGlyZWN0aW9ucy4gU28ga2lsbCBvbmUKPiBhbmQgY2FsbCB0aGUga2VybmVscyBh Z3AgZnVuY3Rpb25zIGRpcmVjdGx5Lgo+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8 ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9kcm1fYWdw c3VwcG9ydC5jIHwgwqAgNDAgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ IMKgZHJpdmVycy9ncHUvZHJtL2RybV9tZW1vcnkuYyDCoCDCoCB8IMKgIDEyICsrLS0tLS0tLS0K PiDCoGluY2x1ZGUvZHJtL2RybVAuaCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB8IMKgIMKgNSAtLS0t Cj4gwqAzIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNTAgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hZ3BzdXBwb3J0LmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2FncHN1cHBvcnQuYwo+IGluZGV4IGJhMzhlMDEuLjI1MmZkYjkgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hZ3BzdXBwb3J0LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2FncHN1cHBvcnQuYwo+IEBAIC0xOTMsNyArMTkzLDcgQEAgaW50IGRybV9h Z3BfZW5hYmxlX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gwqAq IFxyZXR1cm4gemVybyBvbiBzdWNjZXNzIG9yIGEgbmVnYXRpdmUgbnVtYmVyIG9uIGZhaWx1cmUu Cj4gwqAqCj4gwqAqIFZlcmlmaWVzIHRoZSBBR1AgZGV2aWNlIGlzIHByZXNlbnQgYW5kIGhhcyBi ZWVuIGFjcXVpcmVkLCBhbGxvY2F0ZXMgdGhlCj4gLSAqIG1lbW9yeSB2aWEgYWxsb2NfYWdwKCkg YW5kIGNyZWF0ZXMgYSBkcm1fYWdwX21lbSBlbnRyeSBmb3IgaXQuCj4gKyAqIG1lbW9yeSB2aWEg YWdwX2FsbG9jYXRlX21lbW9yeSgpIGFuZCBjcmVhdGVzIGEgZHJtX2FncF9tZW0gZW50cnkgZm9y IGl0Lgo+IMKgKi8KPiDCoGludCBkcm1fYWdwX2FsbG9jKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHN0cnVjdCBkcm1fYWdwX2J1ZmZlciAqcmVxdWVzdCkKPiDCoHsKPiBAQCAtMjExLDcgKzIxMSw3 IEBAIGludCBkcm1fYWdwX2FsbG9jKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1f YWdwX2J1ZmZlciAqcmVxdWVzdCkKPgo+IMKgIMKgIMKgIMKgcGFnZXMgPSAocmVxdWVzdC0+c2l6 ZSArIFBBR0VfU0laRSAtIDEpIC8gUEFHRV9TSVpFOwo+IMKgIMKgIMKgIMKgdHlwZSA9ICh1MzIp IHJlcXVlc3QtPnR5cGU7Cj4gLSDCoCDCoCDCoCBpZiAoIShtZW1vcnkgPSBkcm1fYWxsb2NfYWdw KGRldiwgcGFnZXMsIHR5cGUpKSkgewo+ICsgwqAgwqAgwqAgaWYgKCEobWVtb3J5ID0gYWdwX2Fs bG9jYXRlX21lbW9yeShkZXYtPmFncC0+YnJpZGdlLCBwYWdlcywgdHlwZSkpKSB7Cj4gwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqBrZnJlZShlbnRyeSk7Cj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBy ZXR1cm4gLUVOT01FTTsKPiDCoCDCoCDCoCDCoH0KPiBAQCAtNDIzLDM4ICs0MjMsNiBAQCBzdHJ1 Y3QgZHJtX2FncF9oZWFkICpkcm1fYWdwX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiDC oCDCoCDCoCDCoHJldHVybiBoZWFkOwo+IMKgfQo+Cj4gLS8qKiBDYWxscyBhZ3BfYWxsb2NhdGVf bWVtb3J5KCkgKi8KPiAtRFJNX0FHUF9NRU0gKmRybV9hZ3BfYWxsb2NhdGVfbWVtb3J5KHN0cnVj dCBhZ3BfYnJpZGdlX2RhdGEgKiBicmlkZ2UsCj4gLSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHNpemVfdCBwYWdlcywgdTMyIHR5cGUpCj4gLXsK PiAtIMKgIMKgIMKgIHJldHVybiBhZ3BfYWxsb2NhdGVfbWVtb3J5KGJyaWRnZSwgcGFnZXMsIHR5 cGUpOwo+IC19Cj4gLQo+IC0vKiogQ2FsbHMgYWdwX2ZyZWVfbWVtb3J5KCkgKi8KPiAtaW50IGRy bV9hZ3BfZnJlZV9tZW1vcnkoRFJNX0FHUF9NRU0gKiBoYW5kbGUpCj4gLXsKPiAtIMKgIMKgIMKg IGlmICghaGFuZGxlKQo+IC0gwqAgwqAgwqAgwqAgwqAgwqAgwqAgcmV0dXJuIDA7Cj4gLSDCoCDC oCDCoCBhZ3BfZnJlZV9tZW1vcnkoaGFuZGxlKTsKPiAtIMKgIMKgIMKgIHJldHVybiAxOwo+IC19 Cj4gLQo+IC0vKiogQ2FsbHMgYWdwX2JpbmRfbWVtb3J5KCkgKi8KPiAtaW50IGRybV9hZ3BfYmlu ZF9tZW1vcnkoRFJNX0FHUF9NRU0gKiBoYW5kbGUsIG9mZl90IHN0YXJ0KQo+IC17Cj4gLSDCoCDC oCDCoCBpZiAoIWhhbmRsZSkKPiAtIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHJldHVybiAtRUlOVkFM Owo+IC0gwqAgwqAgwqAgcmV0dXJuIGFncF9iaW5kX21lbW9yeShoYW5kbGUsIHN0YXJ0KTsKPiAt fQo+IC0KPiAtLyoqIENhbGxzIGFncF91bmJpbmRfbWVtb3J5KCkgKi8KPiAtaW50IGRybV9hZ3Bf dW5iaW5kX21lbW9yeShEUk1fQUdQX01FTSAqIGhhbmRsZSkKPiAtewo+IC0gwqAgwqAgwqAgaWYg KCFoYW5kbGUpCj4gLSDCoCDCoCDCoCDCoCDCoCDCoCDCoCByZXR1cm4gLUVJTlZBTDsKPiAtIMKg IMKgIMKgIHJldHVybiBhZ3BfdW5iaW5kX21lbW9yeShoYW5kbGUpOwo+IC19Cj4gLQo+IMKgLyoq Cj4gwqAqIEJpbmRzIGEgY29sbGVjdGlvbiBvZiBwYWdlcyBpbnRvIEFHUCBtZW1vcnkgYXQgdGhl IGdpdmVuIG9mZnNldCwgcmV0dXJuaW5nCj4gwqAqIHRoZSBBR1AgbWVtb3J5IHN0cnVjdHVyZSBj b250YWluaW5nIHRoZW0uCj4gQEAgLTQ3NCw3ICs0NDIsNyBAQCBkcm1fYWdwX2JpbmRfcGFnZXMo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPgo+IMKgIMKgIMKgIMKgRFJNX0RFQlVHKCJcbiIpOwo+ Cj4gLSDCoCDCoCDCoCBtZW0gPSBkcm1fYWdwX2FsbG9jYXRlX21lbW9yeShkZXYtPmFncC0+YnJp ZGdlLCBudW1fcGFnZXMsCj4gKyDCoCDCoCDCoCBtZW0gPSBhZ3BfYWxsb2NhdGVfbWVtb3J5KGRl di0+YWdwLT5icmlkZ2UsIG51bV9wYWdlcywKPiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHR5cGUpOwo+IMKgIMKgIMKgIMKgaWYgKG1lbSA9 PSBOVUxMKSB7Cj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBEUk1fRVJST1IoIkZhaWxlZCB0byBh bGxvY2F0ZSBtZW1vcnkgZm9yICVsZCBwYWdlc1xuIiwKPiBAQCAtNDg3LDcgKzQ1NSw3IEBAIGRy bV9hZ3BfYmluZF9wYWdlcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+IMKgIMKgIMKgIMKgbWVt LT5wYWdlX2NvdW50ID0gbnVtX3BhZ2VzOwo+Cj4gwqAgwqAgwqAgwqBtZW0tPmlzX2ZsdXNoZWQg PSB0cnVlOwo+IC0gwqAgwqAgwqAgcmV0ID0gZHJtX2FncF9iaW5kX21lbW9yeShtZW0sIGd0dF9v ZmZzZXQgLyBQQUdFX1NJWkUpOwo+ICsgwqAgwqAgwqAgcmV0ID0gYWdwX2JpbmRfbWVtb3J5KG1l bSwgZ3R0X29mZnNldCAvIFBBR0VfU0laRSk7Cj4gwqAgwqAgwqAgwqBpZiAocmV0ICE9IDApIHsK PiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoERSTV9FUlJPUigiRmFpbGVkIHRvIGJpbmQgQUdQIG1l bW9yeTogJWRcbiIsIHJldCk7Cj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBhZ3BfZnJlZV9tZW1v cnkobWVtKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9tZW1vcnkuYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fbWVtb3J5LmMKPiBpbmRleCA3MGNhMjdlLi5jOWI4MDUwIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWVtb3J5LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX21lbW9yeS5jCj4gQEAgLTk5LDI5ICs5OSwyMyBAQCBzdGF0aWMgdm9pZCAqYWdw X3JlbWFwKHVuc2lnbmVkIGxvbmcgb2Zmc2V0LCB1bnNpZ25lZCBsb25nIHNpemUsCj4gwqAgwqAg wqAgwqByZXR1cm4gYWRkcjsKPiDCoH0KPgo+IC0vKiogV3JhcHBlciBhcm91bmQgYWdwX2FsbG9j YXRlX21lbW9yeSgpICovCj4gLURSTV9BR1BfTUVNICpkcm1fYWxsb2NfYWdwKHN0cnVjdCBkcm1f ZGV2aWNlICogZGV2LCBpbnQgcGFnZXMsIHUzMiB0eXBlKQo+IC17Cj4gLSDCoCDCoCDCoCByZXR1 cm4gZHJtX2FncF9hbGxvY2F0ZV9tZW1vcnkoZGV2LT5hZ3AtPmJyaWRnZSwgcGFnZXMsIHR5cGUp Owo+IC19Cj4gLQo+IMKgLyoqIFdyYXBwZXIgYXJvdW5kIGFncF9mcmVlX21lbW9yeSgpICovCj4g wqB2b2lkIGRybV9mcmVlX2FncChEUk1fQUdQX01FTSAqIGhhbmRsZSwgaW50IHBhZ2VzKQo+IMKg ewo+IC0gwqAgwqAgwqAgZHJtX2FncF9mcmVlX21lbW9yeShoYW5kbGUpOwo+ICsgwqAgwqAgwqAg YWdwX2ZyZWVfbWVtb3J5KGhhbmRsZSk7Cj4gwqB9Cj4gwqBFWFBPUlRfU1lNQk9MKGRybV9mcmVl X2FncCk7Cj4KPiDCoC8qKiBXcmFwcGVyIGFyb3VuZCBhZ3BfYmluZF9tZW1vcnkoKSAqLwo+IMKg aW50IGRybV9iaW5kX2FncChEUk1fQUdQX01FTSAqIGhhbmRsZSwgdW5zaWduZWQgaW50IHN0YXJ0 KQo+IMKgewo+IC0gwqAgwqAgwqAgcmV0dXJuIGRybV9hZ3BfYmluZF9tZW1vcnkoaGFuZGxlLCBz dGFydCk7Cj4gKyDCoCDCoCDCoCByZXR1cm4gYWdwX2JpbmRfbWVtb3J5KGhhbmRsZSwgc3RhcnQp Owo+IMKgfQo+Cj4gwqAvKiogV3JhcHBlciBhcm91bmQgYWdwX3VuYmluZF9tZW1vcnkoKSAqLwo+ IMKgaW50IGRybV91bmJpbmRfYWdwKERSTV9BR1BfTUVNICogaGFuZGxlKQo+IMKgewo+IC0gwqAg wqAgwqAgcmV0dXJuIGRybV9hZ3BfdW5iaW5kX21lbW9yeShoYW5kbGUpOwo+ICsgwqAgwqAgwqAg cmV0dXJuIGFncF91bmJpbmRfbWVtb3J5KGhhbmRsZSk7Cj4gwqB9Cj4gwqBFWFBPUlRfU1lNQk9M KGRybV91bmJpbmRfYWdwKTsKCkFueSByZWFzb24gdG8ga2VlcCB0aGVzZSBsYXN0IHRocmVlIHdy YXBwZXJzIGFyb3VuZD8KCktyaXN0aWFuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==