From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dima Zavin Subject: Re: [PATCH 0/7] Nexus One Support Date: Sat, 22 Jan 2011 02:35:27 -0800 Message-ID: References: <1295576730.4096.24.camel@Joe-Laptop> <1295624801.19880.13.camel@m0nster> <20110121094827.41818a55@jbarnes-desktop> <20110121095658.1ab623fe@jbarnes-desktop> <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> <20110121234930.GK3043@thunk.org> <1295684398.19231.47.camel@jaguar> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp-out.google.com ([74.125.121.67]:38434 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049Ab1AVKfc convert rfc822-to-8bit (ORCPT ); Sat, 22 Jan 2011 05:35:32 -0500 Received: from hpaq11.eem.corp.google.com (hpaq11.eem.corp.google.com [172.25.149.11]) by smtp-out.google.com with ESMTP id p0MAZULT023333 for ; Sat, 22 Jan 2011 02:35:30 -0800 Received: from qwj8 (qwj8.prod.google.com [10.241.195.72]) by hpaq11.eem.corp.google.com with ESMTP id p0MAZSWq019327 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Sat, 22 Jan 2011 02:35:29 -0800 Received: by qwj8 with SMTP id 8so2599199qwj.38 for ; Sat, 22 Jan 2011 02:35:28 -0800 (PST) In-Reply-To: <1295684398.19231.47.camel@jaguar> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Pekka Enberg Cc: Ted Ts'o , Daniel Walker , Jesse Barnes , Joe Perches , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davidb@codeaurora.org On Sat, Jan 22, 2011 at 12:19 AM, Pekka Enberg wro= te: > Hi Ted, > > On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker wrote: >> > > I'll add this list into the commit text .. > > On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: >> > So why is everyone bitching at Daniel when he's doing something th= e >> > Android folks should have done themselves a long time ago? > > On Fri, 2011-01-21 at 18:49 -0500, Ted Ts'o wrote: >> Two wrongs don't make a right. =A0And it's not like not submitting >> changes is wrong, although granted it's not ideal. =A0(I'd say remov= ing >> attribution from a git commit is even worse. =A0If you're doing the >> equivalent of a cherry pick, you should preserve the Author field. >> Even if you're doing some cleanup work, as the maintainer I generall= y >> preserve the Author line, and will simply add the fact that I did so= me >> cleanup to the commit body. =A0The question is who did more work; th= e >> person who originally submitted the code, or the person who did the >> cleanup.) > > Sure, it would have been nicer for everyone involved if Daniel would > have kept the original patches and added new patches to clean it up o= n > top of that to preserve the history. However, I don't understand the > harsh comments when this looks like a honest mistake! And I especiall= y > don't understand the almost hostile attitude of the Android developer= s There's absolutely no hostility. I stated from the very beginning that I appreciate the voluntary effort by a 3rd party to upstream the board files. I only asked that proper authorship be attributed, which is standard linux kernel patch submission procedure when the committer did not originate the code. > who have been sitting on these patches for over a year now AFAICT. Even if that were true, that does not somehow revoke the original author/contributor list. --Dima -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733Ab1AVKfe (ORCPT ); Sat, 22 Jan 2011 05:35:34 -0500 Received: from smtp-out.google.com ([216.239.44.51]:60532 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752593Ab1AVKfc convert rfc822-to-8bit (ORCPT ); Sat, 22 Jan 2011 05:35:32 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=sFbM4Xt6U+N4TA6OvQAg2i5YVdL8lJlLGyw5fwZRkJ0sHTIm9bt4uYa2K9Kr1uE7g1 obGYNKUEqByHZAmmgpIg== MIME-Version: 1.0 In-Reply-To: <1295684398.19231.47.camel@jaguar> References: <1295576730.4096.24.camel@Joe-Laptop> <1295624801.19880.13.camel@m0nster> <20110121094827.41818a55@jbarnes-desktop> <20110121095658.1ab623fe@jbarnes-desktop> <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> <20110121234930.GK3043@thunk.org> <1295684398.19231.47.camel@jaguar> Date: Sat, 22 Jan 2011 02:35:27 -0800 Message-ID: Subject: Re: [PATCH 0/7] Nexus One Support From: Dima Zavin To: Pekka Enberg Cc: "Ted Ts'o" , Daniel Walker , Jesse Barnes , Joe Perches , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davidb@codeaurora.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 22, 2011 at 12:19 AM, Pekka Enberg wrote: > Hi Ted, > > On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker wrote: >> > > I'll add this list into the commit text .. > > On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: >> > So why is everyone bitching at Daniel when he's doing something the >> > Android folks should have done themselves a long time ago? > > On Fri, 2011-01-21 at 18:49 -0500, Ted Ts'o wrote: >> Two wrongs don't make a right.  And it's not like not submitting >> changes is wrong, although granted it's not ideal.  (I'd say removing >> attribution from a git commit is even worse.  If you're doing the >> equivalent of a cherry pick, you should preserve the Author field. >> Even if you're doing some cleanup work, as the maintainer I generally >> preserve the Author line, and will simply add the fact that I did some >> cleanup to the commit body.  The question is who did more work; the >> person who originally submitted the code, or the person who did the >> cleanup.) > > Sure, it would have been nicer for everyone involved if Daniel would > have kept the original patches and added new patches to clean it up on > top of that to preserve the history. However, I don't understand the > harsh comments when this looks like a honest mistake! And I especially > don't understand the almost hostile attitude of the Android developers There's absolutely no hostility. I stated from the very beginning that I appreciate the voluntary effort by a 3rd party to upstream the board files. I only asked that proper authorship be attributed, which is standard linux kernel patch submission procedure when the committer did not originate the code. > who have been sitting on these patches for over a year now AFAICT. Even if that were true, that does not somehow revoke the original author/contributor list. --Dima From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitriyz@google.com (Dima Zavin) Date: Sat, 22 Jan 2011 02:35:27 -0800 Subject: [PATCH 0/7] Nexus One Support In-Reply-To: <1295684398.19231.47.camel@jaguar> References: <1295576730.4096.24.camel@Joe-Laptop> <1295624801.19880.13.camel@m0nster> <20110121094827.41818a55@jbarnes-desktop> <20110121095658.1ab623fe@jbarnes-desktop> <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> <20110121234930.GK3043@thunk.org> <1295684398.19231.47.camel@jaguar> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Jan 22, 2011 at 12:19 AM, Pekka Enberg wrote: > Hi Ted, > > On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker wrote: >> > > I'll add this list into the commit text .. > > On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: >> > So why is everyone bitching at Daniel when he's doing something the >> > Android folks should have done themselves a long time ago? > > On Fri, 2011-01-21 at 18:49 -0500, Ted Ts'o wrote: >> Two wrongs don't make a right. ?And it's not like not submitting >> changes is wrong, although granted it's not ideal. ?(I'd say removing >> attribution from a git commit is even worse. ?If you're doing the >> equivalent of a cherry pick, you should preserve the Author field. >> Even if you're doing some cleanup work, as the maintainer I generally >> preserve the Author line, and will simply add the fact that I did some >> cleanup to the commit body. ?The question is who did more work; the >> person who originally submitted the code, or the person who did the >> cleanup.) > > Sure, it would have been nicer for everyone involved if Daniel would > have kept the original patches and added new patches to clean it up on > top of that to preserve the history. However, I don't understand the > harsh comments when this looks like a honest mistake! And I especially > don't understand the almost hostile attitude of the Android developers There's absolutely no hostility. I stated from the very beginning that I appreciate the voluntary effort by a 3rd party to upstream the board files. I only asked that proper authorship be attributed, which is standard linux kernel patch submission procedure when the committer did not originate the code. > who have been sitting on these patches for over a year now AFAICT. Even if that were true, that does not somehow revoke the original author/contributor list. --Dima