From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33095 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pivtb-0003QQ-Rt for qemu-devel@nongnu.org; Fri, 28 Jan 2011 16:30:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pivta-0000uN-QN for qemu-devel@nongnu.org; Fri, 28 Jan 2011 16:30:19 -0500 Received: from mail-pv0-f173.google.com ([74.125.83.173]:51215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pivta-0000uH-HJ for qemu-devel@nongnu.org; Fri, 28 Jan 2011 16:30:18 -0500 Received: by pvh11 with SMTP id 11so583911pvh.4 for ; Fri, 28 Jan 2011 13:30:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20110127190744.245670@gmx.com> References: <20110127190744.245670@gmx.com> From: Blue Swirl Date: Fri, 28 Jan 2011 21:29:57 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH] Sun4m / Sun4u : Uppercase RAM_size Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olivier DANET Cc: qemu-devel@nongnu.org On Thu, Jan 27, 2011 at 7:07 PM, Olivier DANET wrote: Please instead describe the patch with something like using the upper case version is more correct because it is the argument of the function. The patch is OK, except that the non-breaking space (0xa0 or UTF-8 0xc2 0xa0) characters confuse git am. Perhaps there is a problem with your email setup? > Signed-off-by: Olivier Danet > --- > =C2=A0hw/sun4m.c =C2=A0=C2=A0=C2=A0 6 +++--- > =C2=A0hw/sun4u.c =C2=A0=C2=A0=C2=A0 4 ++-- > =C2=A02 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/sun4m.c b/hw/sun4m.c > index 30e8a21..8076f25 100644 > --- a/hw/sun4m.c > +++ b/hw/sun4m.c > @@ -962,7 +962,7 @@ static void sun4m_hw_init(const struct sun4m_hwdef *h= wdef, ram_addr_t RAM_size, > > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg =3D fw_cfg_init(0, 0, CFG_ADDR, CFG_ADDR = + 2); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); > -=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)ram= _size); > +=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)RAM= _size); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i16(fw_cfg, FW_CFG_MACHINE_ID, hwdef-= >machine_id); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i16(fw_cfg, FW_CFG_SUN4M_DEPTH, graph= ic_depth); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_ADDR, KERNE= L_LOAD_ADDR); > @@ -1573,7 +1573,7 @@ static void sun4d_hw_init(const struct sun4d_hwdef = *hwdef, ram_addr_t RAM_size, > > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg =3D fw_cfg_init(0, 0, CFG_ADDR, CFG_ADDR = + 2); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); > -=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)ram= _size); > +=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)RAM= _size); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i16(fw_cfg, FW_CFG_MACHINE_ID, hwdef-= >machine_id); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i16(fw_cfg, FW_CFG_SUN4M_DEPTH, graph= ic_depth); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_ADDR, KERNE= L_LOAD_ADDR); > @@ -1765,7 +1765,7 @@ static void sun4c_hw_init(const struct sun4c_hwdef = *hwdef, ram_addr_t RAM_size, > > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg =3D fw_cfg_init(0, 0, CFG_ADDR, CFG_ADDR = + 2); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); > -=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)ram= _size); > +=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)RAM= _size); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i16(fw_cfg, FW_CFG_MACHINE_ID, hwdef-= >machine_id); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i16(fw_cfg, FW_CFG_SUN4M_DEPTH, graph= ic_depth); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_ADDR, KERNE= L_LOAD_ADDR); > diff --git a/hw/sun4u.c b/hw/sun4u.c > index 90b1ce2..23df953 100644 > --- a/hw/sun4u.c > +++ b/hw/sun4u.c > @@ -813,7 +813,7 @@ static void sun4uv_init(ram_addr_t RAM_size, > > =C2=A0=C2=A0=C2=A0=C2=A0 initrd_size =3D 0; > =C2=A0=C2=A0=C2=A0=C2=A0 kernel_size =3D sun4u_load_kernel(kernel_filenam= e, initrd_filename, > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ram_size, &= initrd_size); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 RAM_size, &= initrd_size); > > =C2=A0=C2=A0=C2=A0=C2=A0 sun4u_NVRAM_set_params(nvram, NVRAM_SIZE, "Sun4u= ", RAM_size, boot_devices, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 KERNEL_LOAD_ADDR, kernel_size, > @@ -826,7 +826,7 @@ static void sun4uv_init(ram_addr_t RAM_size, > > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg =3D fw_cfg_init(BIOS_CFG_IOPORT, BIOS_CFG= _IOPORT + 1, 0, 0); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); > -=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)ram= _size); > +=C2=A0=C2=A0=C2=A0 fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)RAM= _size); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i16(fw_cfg, FW_CFG_MACHINE_ID, hwdef-= >machine_id); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_ADDR, KERNE= L_LOAD_ADDR); > =C2=A0=C2=A0=C2=A0=C2=A0 fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_SIZE, kerne= l_size); > -- > 1.6.2.4 > >