From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: mem_sharing: summarized problems when domain is dying Date: Fri, 21 Jan 2011 16:41:47 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0016367f9dc421f211049a5dedc8 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jui-Hao Chiang Cc: MaoXiaoyun , xen devel , Tim Deegan List-Id: xen-devel@lists.xenproject.org --0016367f9dc421f211049a5dedc8 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Tim / Xiaoyun, do you think something like this might work? -George On Fri, Jan 21, 2011 at 4:32 PM, George Dunlap wrote: > [sorry, accidentally sent too early] > > On Fri, Jan 21, 2011 at 4:29 PM, George Dunlap wrote: >> I'm not sure the exact rationale behind the "cannot fail" flag; but it >> looks like in grant_table.c, both callers of gfn_to_mfn_unshare() >> handle the case where the returned p2m entry is just > > ...invalid. =A0I wonder if "unsharing" the page, but marking the entry > invalid during death would help. > > I suppose the problem there is that if you're keeping the VM around > but paused for analysis, you'll have holes in your address space. =A0But > just returning an invalid entry to the callers who try to unshare > pages might work. > > =A0-George > --0016367f9dc421f211049a5dedc8 Content-Type: text/plain; charset=US-ASCII; name="interpret_must_succeed_if_dying.diff" Content-Disposition: attachment; filename="interpret_must_succeed_if_dying.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gj7bjpar0 ZGlmZiAtciA5Y2E5MzMxYzk3ODAgeGVuL2luY2x1ZGUvYXNtLXg4Ni9wMm0uaAotLS0gYS94ZW4v aW5jbHVkZS9hc20teDg2L3AybS5oCUZyaSBKYW4gMjEgMTU6Mzc6MzYgMjAxMSArMDAwMAorKysg Yi94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5oCUZyaSBKYW4gMjEgMTY6NDE6NTggMjAxMSArMDAw MApAQCAtMzkwLDcgKzM5MCwxNCBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtdXN0X3N1Y2NlZWQgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ID8gTUVNX1NIQVJJTkdfTVVTVF9TVUNDRUVEIDogMCkgKQogICAgICAgICB7Ci0gICAgICAgICAg ICBCVUdfT04obXVzdF9zdWNjZWVkKTsKKyAgICAgICAgICAgIGlmICggbXVzdF9zdWNjZWVkCisg ICAgICAgICAgICAgICAgICYmIHAybS0+ZG9tYWluLT5pc19keWluZyApCisgICAgICAgICAgICB7 CisgICAgICAgICAgICAgICAgbWZuID0gSU5WQUxJRF9NRk47CisgICAgICAgICAgICAgICAgKnAy bXQ9cDJtX2ludmFsaWQ7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBlbHNlCisgICAgICAg ICAgICAgICAgQlVHX09OKG11c3Rfc3VjY2VlZCk7CiAgICAgICAgICAgICByZXR1cm4gbWZuOwog ICAgICAgICB9CiAgICAgICAgIG1mbiA9IGdmbl90b19tZm4ocDJtLCBnZm4sIHAybXQpOwo= --0016367f9dc421f211049a5dedc8 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --0016367f9dc421f211049a5dedc8--