From: Nathaniel Smith <njs@pobox.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
bloat-devel@lists.bufferbloat.net, johannes@sipsolutions.net,
nbd@openwrt.org
Subject: Re: [RFC v2] mac80211: implement eBDP algorithm to fight bufferbloat
Date: Fri, 25 Feb 2011 10:27:24 -0800 [thread overview]
Message-ID: <AANLkTinOPNNi8e3NHpFw0ABtF5GBU_NfuMmOxnKKdo1f@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimahYNo0ZHr9PU217CWJQP6ssuhaxguYVz7dX_-@mail.gmail.com>
On Fri, Feb 25, 2011 at 10:21 AM, Nathaniel Smith <njs@pobox.com> wrote:
> static u64 _ktime_diff_to_now_and_unstash(ktime_t then, int * enqueued) {
>
> timespec ts_then = ktime_to_timespec(then);
> timespec ts_now = ktime_to_timespec(ktime_get());
> *enqueued = ts_then.tv_sec >> LATENCY_BITS;
> ts_then.tv_sec &= (1 << LATENCY_BITS) - 1;
> ts_now.tv_sec &= (1 << LATENCY_BITS) - 1;
> if (ts_now.tv_sec < ts_then.tv_sec)
> ts_now.tv_sec += (1 << LATENCY_BITS);
> timespec_sub(ts_now, ts_then);
> }
Err, plus the 'return timespec_to_ns(...)' on the last line, that I
was trying to add when my computer suddenly decided I wanted to send
the message. How embarrassing.
Anyway, not sure this is a *good* idea, but it should work. Hopefully
we don't actually need to measure latencies > 256 seconds in this
context...
-- Nathaniel
next prev parent reply other threads:[~2011-02-25 18:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 17:56 [PATCH 0/5] iwlwifi: Auto-tune tx queue size to maintain latency under load Nathaniel J. Smith
2011-02-13 17:56 ` [PATCH 1/5] iwlwifi: Simplify tx queue management Nathaniel J. Smith
2011-02-14 9:57 ` Johannes Berg
2011-02-14 22:17 ` Nathaniel Smith
2011-02-14 22:45 ` wwguy
2011-02-15 0:15 ` Dave Täht
2011-02-16 9:16 ` Stanislaw Gruszka
2011-02-16 14:41 ` John W. Linville
2011-02-16 15:13 ` wwguy
2011-02-15 12:11 ` Johannes Berg
2011-02-14 15:33 ` wwguy
2011-02-13 17:56 ` [PATCH 2/5] iwlwifi: Convert the tx queue high_mark to an atomic_t Nathaniel J. Smith
2011-02-14 12:16 ` Johannes Berg
2011-02-14 22:35 ` Nathaniel Smith
2011-02-15 12:08 ` Johannes Berg
2011-02-15 17:37 ` Nathaniel Smith
2011-02-13 17:56 ` [PATCH 3/5] iwlwifi: Invert the sense of the queue high_mark Nathaniel J. Smith
2011-02-13 17:56 ` [PATCH 4/5] iwlwifi: auto-tune tx queue size to minimize latency Nathaniel J. Smith
2011-02-14 12:17 ` Johannes Berg
2011-02-14 21:58 ` Nathaniel Smith
2011-02-15 12:13 ` Johannes Berg
2011-02-15 15:03 ` John W. Linville
2011-02-16 8:59 ` Johannes Berg
2011-02-15 17:31 ` Nathaniel Smith
2011-02-14 15:46 ` wwguy
2011-02-13 17:56 ` [PATCH 5/5] iwlwifi: make current tx queue sizes visible in debugfs Nathaniel J. Smith
2011-02-14 0:32 ` [PATCH 0/5] iwlwifi: Auto-tune tx queue size to maintain latency under load Julian Calaby
2011-02-14 3:28 ` Nathaniel Smith
2011-02-16 15:50 ` John W. Linville
2011-02-16 23:08 ` Nathaniel Smith
2011-02-16 23:42 ` wwguy
2011-02-17 1:49 ` [RFC] mac80211: implement eBDP algorithm to fight bufferbloat John W. Linville
2011-02-17 3:31 ` Ben Greear
2011-02-17 4:26 ` Nathaniel Smith
2011-02-17 8:31 ` Johannes Berg
2011-02-18 21:21 ` [RFC v2] " John W. Linville
2011-02-19 3:44 ` Nathaniel Smith
2011-02-21 18:47 ` John W. Linville
2011-02-21 23:26 ` Nathaniel Smith
2011-02-23 22:28 ` John W. Linville
2011-02-25 18:21 ` Nathaniel Smith
2011-02-25 18:27 ` Nathaniel Smith [this message]
2011-02-20 0:37 ` Nathaniel Smith
2011-02-21 18:52 ` John W. Linville
2011-02-21 15:28 ` Johannes Berg
2011-02-21 19:06 ` John W. Linville
2011-02-21 20:26 ` Tianji Li
2011-02-28 13:07 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinOPNNi8e3NHpFw0ABtF5GBU_NfuMmOxnKKdo1f@mail.gmail.com \
--to=njs@pobox.com \
--cc=bloat-devel@lists.bufferbloat.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.