From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Turner Subject: Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts Date: Mon, 6 Dec 2010 18:04:26 +0000 Message-ID: References: <1291617494-18430-1-git-send-email-mattst88@gmail.com> <20101206173040.GA18372@ericsson.com> <20101206180203.GA18478@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20101206180203.GA18478@ericsson.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: Guenter Roeck Cc: Jean Delvare , "linux-i2c@vger.kernel.org" , "linux-mips@linux-mips.org" , Ralf Baechle , "Maciej W. Rozycki" List-Id: linux-i2c@vger.kernel.org On Mon, Dec 6, 2010 at 6:02 PM, Guenter Roeck wrote: > On Mon, Dec 06, 2010 at 12:40:15PM -0500, Matt Turner wrote: >> On Mon, Dec 6, 2010 at 5:30 PM, Guenter Roeck >> wrote: >> > On Mon, Dec 06, 2010 at 01:38:14AM -0500, Matt Turner wrote: >> >> From: Maciej W. Rozycki >> >> >> >> This is a rewrite of large parts of the driver mainly so that it uses >> >> SMBus interrupts to offload the CPU from busy-waiting on status inputs. >> >> As a part of the overhaul of the init and exit calls, all accesses to the >> >> hardware got converted to use accessory functions via an ioremap() cookie. >> >> >> >> Minimally rebased by Matt Turner. >> >> >> >> Tested-by: Matt Turner >> >> Signed-off-by: Matt Turner >> > >> > >> > I applied the patch to my 1480 tree. Unfortunately, it doesn't work with my system. >> > As far as I can see, the driver does not get any interrupts. >> > >> > My tree is 2.6.32, though. Do you know if I might be missing some other relevant patch ? >> > >> > Thanks, >> > Guenter >> >> I think this patch depends on >> http://www.linux-mips.org/archives/linux-mips/2010-12/msg00030.html >> > I did apply the second patch as well, since you had mentioned it in your patch. > That did not help, though. Frankly, I don't see the dependency in the first place - the other > patch only affects drivers/rtc/rtc-m41t80.c, and I would hope that SMBus support does not depend > on an rtc driver. Am I missing something ? > > Thanks, > Guenter Indeed that does not make much sense. I really don't know. Perhaps Maciej can shed some light on this? It certainly might be the case that these patches haven't ever been tested on a BCM91480 before. Matt