From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cory Maccarrone Subject: Re: [PATCH] Keyboard: omap-keypad: use matrix_keypad.h Date: Fri, 17 Dec 2010 21:38:20 -0800 Message-ID: References: <201012172332.06480.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:47065 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294Ab0LRFim convert rfc822-to-8bit (ORCPT ); Sat, 18 Dec 2010 00:38:42 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Janusz Krzysztofik Cc: linux-omap@vger.kernel.org, linux-input@vger.kernel.org, Tony Lindgren , Dmitry Torokhov , linux-arm-kernel@lists.infradead.org On Fri, Dec 17, 2010 at 9:29 PM, Cory Maccarrone wrote: > On Fri, Dec 17, 2010 at 8:29 PM, Cory Maccarrone wrote: >> On Fri, Dec 17, 2010 at 2:32 PM, Janusz Krzysztofik >> wrote: >>> Most keypad drivers make use of the >>> defined macros, structures and inline functions. >>> >>> Convert omap-keypad driver to use those as well, as suggested by a >>> compile time warning, hardcoded into the OMAP . >>> >>> Created against linux-2.6.37-rc5. >>> Tested on Amstrad Delta. >>> Compile tested with omap1_defconfig and omap2plus_defconfig shrinke= d to >>> board-h4. >>> >>> Signed-off-by: Janusz Krzysztofik >>> --- >> >> Works perfectly on the herald, and no more warning message. =C2=A0Go= od work! >> >> Tested-by: Cory Maccarrone >> >> - Cory >> > > Hmm, I may have spoken too soon. =C2=A0This works perfectly on the la= test > Torvalds master branch, but does not seem to work applied to > linux-omap/master. =C2=A0There, all my keys report the same KEY_RECOR= D > event. > > Probably not a problem in this patch, I think -- will try and track i= t > down. =C2=A0Out of curiosity, which branch did you test it on? > > - Cory > OK, looks like it definitely isn't this patch, something else on linux-omap/master broke it. I'll bisect and see if I can figure it out. - Cory -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: darkstar6262@gmail.com (Cory Maccarrone) Date: Fri, 17 Dec 2010 21:38:20 -0800 Subject: [PATCH] Keyboard: omap-keypad: use matrix_keypad.h In-Reply-To: References: <201012172332.06480.jkrzyszt@tis.icnet.pl> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Dec 17, 2010 at 9:29 PM, Cory Maccarrone wrote: > On Fri, Dec 17, 2010 at 8:29 PM, Cory Maccarrone wrote: >> On Fri, Dec 17, 2010 at 2:32 PM, Janusz Krzysztofik >> wrote: >>> Most keypad drivers make use of the >>> defined macros, structures and inline functions. >>> >>> Convert omap-keypad driver to use those as well, as suggested by a >>> compile time warning, hardcoded into the OMAP . >>> >>> Created against linux-2.6.37-rc5. >>> Tested on Amstrad Delta. >>> Compile tested with omap1_defconfig and omap2plus_defconfig shrinked to >>> board-h4. >>> >>> Signed-off-by: Janusz Krzysztofik >>> --- >> >> Works perfectly on the herald, and no more warning message. ?Good work! >> >> Tested-by: Cory Maccarrone >> >> - Cory >> > > Hmm, I may have spoken too soon. ?This works perfectly on the latest > Torvalds master branch, but does not seem to work applied to > linux-omap/master. ?There, all my keys report the same KEY_RECORD > event. > > Probably not a problem in this patch, I think -- will try and track it > down. ?Out of curiosity, which branch did you test it on? > > - Cory > OK, looks like it definitely isn't this patch, something else on linux-omap/master broke it. I'll bisect and see if I can figure it out. - Cory