All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@adurom.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] wl1251: fix ELP_CTRL register reads
Date: Sat, 5 Jun 2010 10:04:24 +0300	[thread overview]
Message-ID: <AANLkTinqgUGCjCBzg8j7bXGY05EW3-jfW7vlnrvCuwRd@mail.gmail.com> (raw)
In-Reply-To: <1275693948-3189-2-git-send-email-notasas@gmail.com>

On 5 June 2010 02:25, Grazvydas Ignotas <notasas@gmail.com> wrote:
> Reading the ELP_CTRL register with sdio_readb causes problems because
> hardware seems to be performing a write using stuff bits in the request
> (those bits contain write data in write request). This indicates that it
> actually expects RAW (read after write) type of request, so perform that
> when reading ELP_CTRL instead. Also cache last written value so we know
> what to write when doing RAW request.
>
> Because of the above it was not possible to wake the chip from ELP power
> saving mode, PM had to be disabled to have the driver usable in SDIO
> mode. After this patch PM is functional.

Excellent that Power Save is now working SDIO. Thank you very much!

> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>

Acked-by: Kalle Valo <kvalo@adurom.com>

> this patch is not suitable for backporting because reqiured SDIO function
> was only merged during the last merge window.

Usually information like this is good to store in the commit log
itself so that it gets properly archived.

Kalle

  reply	other threads:[~2010-06-05  7:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 23:25 [PATCH 1/2] wl1251: fix a memory leak in probe Grazvydas Ignotas
2010-06-04 23:25 ` [PATCH 2/2] wl1251: fix ELP_CTRL register reads Grazvydas Ignotas
2010-06-05  7:04   ` Kalle Valo [this message]
2010-06-21 12:46     ` Denis 'GNUtoo' Carikli
2010-06-21 17:54       ` Bob Copeland
2010-06-21 18:45         ` Denis 'GNUtoo' Carikli
2010-06-21 22:48           ` Grazvydas Ignotas
2010-06-22 23:33             ` Denis 'GNUtoo' Carikli
2010-06-24 23:09               ` Denis 'GNUtoo' Carikli
2010-06-24 23:34                 ` Grazvydas Ignotas
2010-06-25 16:01                   ` Denis 'GNUtoo' Carikli
2010-06-25 18:06                     ` Denis 'GNUtoo' Carikli
2010-06-05  7:00 ` [PATCH 1/2] wl1251: fix a memory leak in probe Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinqgUGCjCBzg8j7bXGY05EW3-jfW7vlnrvCuwRd@mail.gmail.com \
    --to=kvalo@adurom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=notasas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.