From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lei Wen Date: Wed, 26 Jan 2011 16:08:44 +0800 Subject: [U-Boot] [PATCH V2 4/5] mvmfp: add MFP configuration support for PANTHEON In-Reply-To: <20110126080644.B5F75BB0B9@gemini.denx.de> References: <1294632087-8025-1-git-send-email-leiwen@marvell.com> <1294632087-8025-5-git-send-email-leiwen@marvell.com> <20110125213419.5C9431365DB@gemini.denx.de> <20110126073930.12A4CBB0B9@gemini.denx.de> <20110126080644.B5F75BB0B9@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On Wed, Jan 26, 2011 at 4:06 PM, Wolfgang Denk wrote: > Dear Lei Wen, > > In message you wrote: >> >> >> > Please fix. Also, please explain what MFP is. It may be obvious to >> >> > you, it ain't so for me. >> >> MFP is stand for multiply function pin setting, which servers for >> setting a pin of cpu to server for different >> functions on different design boards to better suit for its design. > > multiply or multiple? Sorry for my poor English. It is multiple. > > Maybe you can write something like "Add support for multiple function > pin (MFP) for Marvell PANTHEON SoCs" in your commit message. > > Otherwise people might wonder what Multi Function Peripherals or Multi > Function Printers have to do with that. > Agree. Fix it in next patch set... Best regards, Lei