All of lore.kernel.org
 help / color / mirror / Atom feed
From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: print FPGA info on plat-versatile variants
Date: Mon, 24 Jan 2011 20:05:36 +0100	[thread overview]
Message-ID: <AANLkTintRdFf0RaK6kEtT-Tsy2NvYPhK43NqcLMnV_bT@mail.gmail.com> (raw)
In-Reply-To: <20110124173004.GA27080@n2100.arm.linux.org.uk>

2011/1/24 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Mon, Oct 18, 2010 at 07:23:55PM +0200, Linus Walleij wrote:
>> This adds a small piece of code that displays some basic FPGA
>> characteristics for the Integrator, Versatile, RealView and
>> Versatile Express reference platforms, then hooks it into
>> respective platform startup code.
>
> Firstly, isn't this shown on the character LCD screen at boot, so I wonder
> what the value of this is.

Two things: the RealView EB, PB11MPCore, PBA8, PBA9 nor
the integrator board have the character LCD.

Then I've added a driver for the Char LCD so that you loose this
information if you use the LCD for anything, but yes, it is available
while booting.

> Secondly, with your revised patch, it could really do without adding more
> non-timer stuff back into the timer initialization function when I've just
> removed non-timer stuff from it. ?I don't see that there's anything
> particularly urgent about printing this information, so can't it be a
> normal initcall?

No problem, this was mainly to get it out as early as possible.
I'll fix it up.

Thanks,
Linus Walleij

  reply	other threads:[~2011-01-24 19:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-18 17:23 [PATCH] ARM: print FPGA info on plat-versatile variants Linus Walleij
2011-01-24 17:30 ` Russell King - ARM Linux
2011-01-24 19:05   ` Linus Walleij [this message]
2011-01-27 11:48 Linus Walleij
2011-01-30 19:59 ` Russell King - ARM Linux
2011-01-31 10:26   ` Linus Walleij
2011-01-31 10:58     ` Colin Tuckley
2011-01-31 18:13   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTintRdFf0RaK6kEtT-Tsy2NvYPhK43NqcLMnV_bT@mail.gmail.com \
    --to=linus.ml.walleij@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.