From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dima Zavin <dmitriyz@google.com>
Subject: Re: [PATCH 0/7] Nexus One Support
Date: Sat, 22 Jan 2011 10:15:42 -0800
Message-ID: <AANLkTinv0KJgi3gq4+F+syi4wXD63_8GvbokjviBVBZp@mail.gmail.com>
References: <1295576730.4096.24.camel@Joe-Laptop>
	<1295624801.19880.13.camel@m0nster>
	<20110121094827.41818a55@jbarnes-desktop>
	<20110121095658.1ab623fe@jbarnes-desktop>
	<1295632828.19880.22.camel@m0nster>
	<20110121100441.06a94482@jbarnes-desktop>
	<1295633882.19880.31.camel@m0nster>
	<AANLkTi=L+MW5-KLP_TKSxhstD8JEtBW=RKci5wSbZsd6@mail.gmail.com>
	<1295642995.19880.42.camel@m0nster>
	<AANLkTikVDn+W8t7KSym5tCGZowyYvoLFrk8d0mumiRF-@mail.gmail.com>
	<20110121234930.GK3043@thunk.org>
	<1295684398.19231.47.camel@jaguar>
	<AANLkTinEnNYjhA2WRD=1AqmHYY3ec0uJxRVmLW57_EU=@mail.gmail.com>
	<AANLkTikrDxtkVFJ0C-SwH9QCq4m0A2KMp0vAFA=PaSGM@mail.gmail.com>
	<alpine.LFD.2.00.1101221802280.31804@localhost6.localdomain6>
	<1295719626.2827.18.camel@gnutoo-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from smtp-out.google.com ([74.125.121.67]:43330 "EHLO
	smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751116Ab1AVSPp convert rfc822-to-8bit (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Sat, 22 Jan 2011 13:15:45 -0500
Received: from hpaq1.eem.corp.google.com (hpaq1.eem.corp.google.com [172.25.149.1])
	by smtp-out.google.com with ESMTP id p0MIFiLF004828
	for <linux-arm-msm@vger.kernel.org>; Sat, 22 Jan 2011 10:15:44 -0800
Received: from qyk27 (qyk27.prod.google.com [10.241.83.155])
	by hpaq1.eem.corp.google.com with ESMTP id p0MIF0Ff025655
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT)
	for <linux-arm-msm@vger.kernel.org>; Sat, 22 Jan 2011 10:15:43 -0800
Received: by qyk27 with SMTP id 27so3194804qyk.15
        for <linux-arm-msm@vger.kernel.org>; Sat, 22 Jan 2011 10:15:42 -0800 (PST)
In-Reply-To: <1295719626.2827.18.camel@gnutoo-laptop>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Pekka Enberg <penberg@kernel.org>, Ted Ts'o <tytso@mit.edu>, Daniel Walker <dwalker@codeaurora.org>, Jesse Barnes <jbarnes@virtuousgeek.org>, Joe Perches <joe@perches.com>, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davidb@codeaurora.org

Denis,

Your approach would have been fine as well. Some mechanism to point
out where the original lives like pasting a link saying 'Original code
can be found in <url>" or "Based on the code as found in <url>" as you
did would have also been enough as well.

--Dima

On Sat, Jan 22, 2011 at 10:07 AM, Denis 'GNUtoo' Carikli
<GNUtoo@no-log.org> wrote:
> On Sat, 2011-01-22 at 18:28 +0100, Thomas Gleixner wrote:
>> I really appreciate the well structured effort which Daniel is putti=
ng
>> into this.
> Me too.
>
>
> I've an issue similar to the problem mentioned in this thread:
> I own a board which came,by default with a 2.6.27 kernel.
> A developer of the company that produced and sell the board ported th=
e
> board to the 2.6.30 kernel during his spare time(if I remember well)
> The patch is publicly available in their svn tree in the form of a
> standard unified diff patch(not a git patch)
>
> Is that the proper format for the commit message:
> =A0 =A0mx31: add support for the bugbase 1.3 from buglabs
>
> =A0 =A0This work was based on bug-linux-2.6.30.patch that can be foun=
d
> =A0 =A0 =A0in buglabs's svn here:
> =A0 =A0 =A0svn://bugcamp.net/bug/branches/izzy/experimental
>
> =A0 =A0Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
>
> The work I did was porting forward the board initialization code and =
the
> serial port support from 2.6.30 to linux-next.
> I debugged(with md in uboot to get the printk buffer) the fact that t=
he
> serial didn't work,and removed unneeded code to make it work.
>
> I've not submitted yet the work because of this thread,
> thanks to Russell King's response I think I'll submit it.
>
>
> Here's another commit I made and that went into mainline:
> commit 9df86e2e702c6d5547aced7f241addd2d698bb11
> Author: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> Date: =A0 Fri Aug 27 23:48:19 2010 +0200
>
> wl1251: Fix queue stopping/waking for TX path
>
> This patch was adapted from 06f7bc7db79fabe6b2ec16eff0f59e4acc21eb72
> (from linus's linux-2.6 tree of kernel.org)
>
> here's the original message:
> =A0 =A0The queue stopping/waking functionality was broken in a way th=
at
> could
> =A0 =A0cause huge latencies in TX transfers and even cause the TX to =
stall
> in the
> =A0 =A0right circumstances. Correct these problems.
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> Acked-by: Kalle Valo <kvalo@adurom.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> In this commit I was told not to put the original sign-off, authors
> etc...
> This is because it would have been confusing and misleading:
> It would have appeared like if the commit got Ack,Sign-off etc... by =
the
> people involved in the original commit.
>
> Denis.
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm=
" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752925Ab1AVSPr (ORCPT <rfc822;w@1wt.eu>);
	Sat, 22 Jan 2011 13:15:47 -0500
Received: from smtp-out.google.com ([216.239.44.51]:58172 "EHLO
	smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752123Ab1AVSPp convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 22 Jan 2011 13:15:45 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=google.com; s=beta;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=YZzmriscC22+Y9soMakZ54CHs3LsbNobmr8whh9BM/Rt751qieBBjXd+lNG+NxuERX
         7IDgS0A0H/6fpmyzMhBQ==
MIME-Version: 1.0
In-Reply-To: <1295719626.2827.18.camel@gnutoo-laptop>
References: <1295576730.4096.24.camel@Joe-Laptop>
	<1295624801.19880.13.camel@m0nster>
	<20110121094827.41818a55@jbarnes-desktop>
	<20110121095658.1ab623fe@jbarnes-desktop>
	<1295632828.19880.22.camel@m0nster>
	<20110121100441.06a94482@jbarnes-desktop>
	<1295633882.19880.31.camel@m0nster>
	<AANLkTi=L+MW5-KLP_TKSxhstD8JEtBW=RKci5wSbZsd6@mail.gmail.com>
	<1295642995.19880.42.camel@m0nster>
	<AANLkTikVDn+W8t7KSym5tCGZowyYvoLFrk8d0mumiRF-@mail.gmail.com>
	<20110121234930.GK3043@thunk.org>
	<1295684398.19231.47.camel@jaguar>
	<AANLkTinEnNYjhA2WRD=1AqmHYY3ec0uJxRVmLW57_EU=@mail.gmail.com>
	<AANLkTikrDxtkVFJ0C-SwH9QCq4m0A2KMp0vAFA=PaSGM@mail.gmail.com>
	<alpine.LFD.2.00.1101221802280.31804@localhost6.localdomain6>
	<1295719626.2827.18.camel@gnutoo-laptop>
Date: Sat, 22 Jan 2011 10:15:42 -0800
Message-ID: <AANLkTinv0KJgi3gq4+F+syi4wXD63_8GvbokjviBVBZp@mail.gmail.com>
Subject: Re: [PATCH 0/7] Nexus One Support
From: Dima Zavin <dmitriyz@google.com>
To: "Denis 'GNUtoo' Carikli" <GNUtoo@no-log.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Pekka Enberg <penberg@kernel.org>,
        "Ted Ts'o" <tytso@mit.edu>, Daniel Walker <dwalker@codeaurora.org>,
        Jesse Barnes <jbarnes@virtuousgeek.org>, Joe Perches <joe@perches.com>,
        linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, davidb@codeaurora.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
X-System-Of-Record: true
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Denis,

Your approach would have been fine as well. Some mechanism to point
out where the original lives like pasting a link saying 'Original code
can be found in <url>" or "Based on the code as found in <url>" as you
did would have also been enough as well.

--Dima

On Sat, Jan 22, 2011 at 10:07 AM, Denis 'GNUtoo' Carikli
<GNUtoo@no-log.org> wrote:
> On Sat, 2011-01-22 at 18:28 +0100, Thomas Gleixner wrote:
>> I really appreciate the well structured effort which Daniel is putting
>> into this.
> Me too.
>
>
> I've an issue similar to the problem mentioned in this thread:
> I own a board which came,by default with a 2.6.27 kernel.
> A developer of the company that produced and sell the board ported the
> board to the 2.6.30 kernel during his spare time(if I remember well)
> The patch is publicly available in their svn tree in the form of a
> standard unified diff patch(not a git patch)
>
> Is that the proper format for the commit message:
>    mx31: add support for the bugbase 1.3 from buglabs
>
>    This work was based on bug-linux-2.6.30.patch that can be found
>      in buglabs's svn here:
>      svn://bugcamp.net/bug/branches/izzy/experimental
>
>    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
>
> The work I did was porting forward the board initialization code and the
> serial port support from 2.6.30 to linux-next.
> I debugged(with md in uboot to get the printk buffer) the fact that the
> serial didn't work,and removed unneeded code to make it work.
>
> I've not submitted yet the work because of this thread,
> thanks to Russell King's response I think I'll submit it.
>
>
> Here's another commit I made and that went into mainline:
> commit 9df86e2e702c6d5547aced7f241addd2d698bb11
> Author: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> Date:   Fri Aug 27 23:48:19 2010 +0200
>
> wl1251: Fix queue stopping/waking for TX path
>
> This patch was adapted from 06f7bc7db79fabe6b2ec16eff0f59e4acc21eb72
> (from linus's linux-2.6 tree of kernel.org)
>
> here's the original message:
>    The queue stopping/waking functionality was broken in a way that
> could
>    cause huge latencies in TX transfers and even cause the TX to stall
> in the
>    right circumstances. Correct these problems.
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> Acked-by: Kalle Valo <kvalo@adurom.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> In this commit I was told not to put the original sign-off, authors
> etc...
> This is because it would have been confusing and misleading:
> It would have appeared like if the commit got Ack,Sign-off etc... by the
> people involved in the original commit.
>
> Denis.
>
>
>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: dmitriyz@google.com (Dima Zavin)
Date: Sat, 22 Jan 2011 10:15:42 -0800
Subject: [PATCH 0/7] Nexus One Support
In-Reply-To: <1295719626.2827.18.camel@gnutoo-laptop>
References: <1295576730.4096.24.camel@Joe-Laptop>
	<1295624801.19880.13.camel@m0nster>
	<20110121094827.41818a55@jbarnes-desktop>
	<20110121095658.1ab623fe@jbarnes-desktop>
	<1295632828.19880.22.camel@m0nster>
	<20110121100441.06a94482@jbarnes-desktop>
	<1295633882.19880.31.camel@m0nster>
	<AANLkTi=L+MW5-KLP_TKSxhstD8JEtBW=RKci5wSbZsd6@mail.gmail.com>
	<1295642995.19880.42.camel@m0nster>
	<AANLkTikVDn+W8t7KSym5tCGZowyYvoLFrk8d0mumiRF-@mail.gmail.com>
	<20110121234930.GK3043@thunk.org>
	<1295684398.19231.47.camel@jaguar>
	<AANLkTinEnNYjhA2WRD=1AqmHYY3ec0uJxRVmLW57_EU=@mail.gmail.com>
	<AANLkTikrDxtkVFJ0C-SwH9QCq4m0A2KMp0vAFA=PaSGM@mail.gmail.com>
	<alpine.LFD.2.00.1101221802280.31804@localhost6.localdomain6>
	<1295719626.2827.18.camel@gnutoo-laptop>
Message-ID: <AANLkTinv0KJgi3gq4+F+syi4wXD63_8GvbokjviBVBZp@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Denis,

Your approach would have been fine as well. Some mechanism to point
out where the original lives like pasting a link saying 'Original code
can be found in <url>" or "Based on the code as found in <url>" as you
did would have also been enough as well.

--Dima

On Sat, Jan 22, 2011 at 10:07 AM, Denis 'GNUtoo' Carikli
<GNUtoo@no-log.org> wrote:
> On Sat, 2011-01-22 at 18:28 +0100, Thomas Gleixner wrote:
>> I really appreciate the well structured effort which Daniel is putting
>> into this.
> Me too.
>
>
> I've an issue similar to the problem mentioned in this thread:
> I own a board which came,by default with a 2.6.27 kernel.
> A developer of the company that produced and sell the board ported the
> board to the 2.6.30 kernel during his spare time(if I remember well)
> The patch is publicly available in their svn tree in the form of a
> standard unified diff patch(not a git patch)
>
> Is that the proper format for the commit message:
> ? ?mx31: add support for the bugbase 1.3 from buglabs
>
> ? ?This work was based on bug-linux-2.6.30.patch that can be found
> ? ? ?in buglabs's svn here:
> ? ? ?svn://bugcamp.net/bug/branches/izzy/experimental
>
> ? ?Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
>
> The work I did was porting forward the board initialization code and the
> serial port support from 2.6.30 to linux-next.
> I debugged(with md in uboot to get the printk buffer) the fact that the
> serial didn't work,and removed unneeded code to make it work.
>
> I've not submitted yet the work because of this thread,
> thanks to Russell King's response I think I'll submit it.
>
>
> Here's another commit I made and that went into mainline:
> commit 9df86e2e702c6d5547aced7f241addd2d698bb11
> Author: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> Date: ? Fri Aug 27 23:48:19 2010 +0200
>
> wl1251: Fix queue stopping/waking for TX path
>
> This patch was adapted from 06f7bc7db79fabe6b2ec16eff0f59e4acc21eb72
> (from linus's linux-2.6 tree of kernel.org)
>
> here's the original message:
> ? ?The queue stopping/waking functionality was broken in a way that
> could
> ? ?cause huge latencies in TX transfers and even cause the TX to stall
> in the
> ? ?right circumstances. Correct these problems.
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> Acked-by: Kalle Valo <kvalo@adurom.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> In this commit I was told not to put the original sign-off, authors
> etc...
> This is because it would have been confusing and misleading:
> It would have appeared like if the commit got Ack,Sign-off etc... by the
> people involved in the original commit.
>
> Denis.
>
>
>