From: Nick Kossifidis <mickflemm@gmail.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Bruno Randolf <br1@einfach.org>,
jirislaby@gmail.com, lrodriguez@atheros.com
Subject: Re: [PATCH 1/2] ath5k: fix error handling in ath5k_hw_dma_stop
Date: Wed, 26 Jan 2011 19:06:02 +0200 [thread overview]
Message-ID: <AANLkTinx1Tpp10ToiVB-VuGt01iwDFhWrmw0Tf3o9BVu@mail.gmail.com> (raw)
In-Reply-To: <20110126015034.GA8600@hash.localnet>
2011/1/26 Bob Copeland <me@bobcopeland.com>:
>
> As a side note, we still quit when the first error is encountered.
> Maybe we should try stopping all of the queues anyway if one fails?
> On the other hand we could spend a lot of time polling the registers
> if the card is truly hosed, so I think this is best for now.
>
It's better to continue with hw reset if a queue fails to stop, it
usually means the dma unit needs reset.
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
next prev parent reply other threads:[~2011-01-26 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 4:31 [PATCH 1/2] ath5k: fix error handling in ath5k_hw_dma_stop Bob Copeland
2011-01-25 4:31 ` [PATCH 2/2] ath5k: correct endianness of frame duration Bob Copeland
2011-01-25 5:23 ` Bruno Randolf
2011-01-25 10:38 ` Bob Copeland
2011-01-25 10:47 ` Bruno Randolf
2011-01-26 16:17 ` Bob Copeland
2011-01-25 12:26 ` Nick Kossifidis
2011-01-25 5:12 ` [PATCH 1/2] ath5k: fix error handling in ath5k_hw_dma_stop Bruno Randolf
2011-01-25 12:24 ` Nick Kossifidis
2011-01-25 13:52 ` Stanislaw Gruszka
2011-01-26 1:50 ` Bob Copeland
2011-01-26 7:05 ` Stanislaw Gruszka
2011-01-26 17:06 ` Nick Kossifidis [this message]
2011-01-26 19:28 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinx1Tpp10ToiVB-VuGt01iwDFhWrmw0Tf3o9BVu@mail.gmail.com \
--to=mickflemm@gmail.com \
--cc=br1@einfach.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.