From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-iw0-f170.google.com (mail-iw0-f170.google.com [209.85.214.170]) by ozlabs.org (Postfix) with ESMTP id 0FE6F1007D2 for ; Tue, 14 Sep 2010 00:35:45 +1000 (EST) Received: by iwn37 with SMTP id 37so6010755iwn.15 for ; Mon, 13 Sep 2010 07:35:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1284388075.10955.51.camel@localhost> References: <1284027632-32573-1-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-2-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-3-git-send-email-tie-fei.zang@freescale.com> <20100909114153.GB6622@oksana.dev.rtsoft.ru> <3850A844E6A3854C827AC5C0BEC7B60A1FC158@zch01exm23.fsl.freescale.net> <1284388075.10955.51.camel@localhost> From: Timur Tabi Date: Mon, 13 Sep 2010 09:35:14 -0500 Message-ID: Subject: Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode To: dedekind1@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Cc: Wood Scott-B07421 , Zang Roy-R61911 , Lan Chunhe-B25806 , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, akpm@linux-foundation.org, dwmw2@infradead.org, Gala Kumar-B11780 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Sep 13, 2010 at 9:27 AM, Artem Bityutskiy wrote: > Yes, sizeof(int) == 4 assumption is not good. > > But sizeof(int) >= 4 is perfectly fine. I have to disagree. I don't see how you can say that == is not okay, but >= is okay. That just doesn't make any sense. Obviously, you have to make some assumptions about sizeof(int), but that assumption should be nothing more than "it should be big enough for these small numbers that I'm using". > I see people use u32 and the friends too much. I agree with that. -- Timur Tabi Linux kernel developer at Freescale From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-iw0-f177.google.com ([209.85.214.177]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OvA8K-0003fM-9r for linux-mtd@lists.infradead.org; Mon, 13 Sep 2010 14:35:53 +0000 Received: by iwn36 with SMTP id 36so4688203iwn.36 for ; Mon, 13 Sep 2010 07:35:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1284388075.10955.51.camel@localhost> References: <1284027632-32573-1-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-2-git-send-email-tie-fei.zang@freescale.com> <1284027632-32573-3-git-send-email-tie-fei.zang@freescale.com> <20100909114153.GB6622@oksana.dev.rtsoft.ru> <3850A844E6A3854C827AC5C0BEC7B60A1FC158@zch01exm23.fsl.freescale.net> <1284388075.10955.51.camel@localhost> From: Timur Tabi Date: Mon, 13 Sep 2010 09:35:14 -0500 Message-ID: Subject: Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode To: dedekind1@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Cc: Wood Scott-B07421 , Zang Roy-R61911 , Lan Chunhe-B25806 , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Anton Vorontsov , akpm@linux-foundation.org, dwmw2@infradead.org, Gala Kumar-B11780 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Sep 13, 2010 at 9:27 AM, Artem Bityutskiy wrote: > Yes, sizeof(int) == 4 assumption is not good. > > But sizeof(int) >= 4 is perfectly fine. I have to disagree. I don't see how you can say that == is not okay, but >= is okay. That just doesn't make any sense. Obviously, you have to make some assumptions about sizeof(int), but that assumption should be nothing more than "it should be big enough for these small numbers that I'm using". > I see people use u32 and the friends too much. I agree with that. -- Timur Tabi Linux kernel developer at Freescale