From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757355AbcJ3U3S (ORCPT ); Sun, 30 Oct 2016 16:29:18 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44075 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754065AbcJ3U3R (ORCPT ); Sun, 30 Oct 2016 16:29:17 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20161030200409.GA14808@basecamp.onstation.org> References: <1477648821-3786-1-git-send-email-masneyb@onstation.org> <1477648821-3786-8-git-send-email-masneyb@onstation.org> <20161030200409.GA14808@basecamp.onstation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec From: Jonathan Cameron Date: Sun, 30 Oct 2016 20:29:07 +0000 To: Brian Masney , Jonathan Cameron CC: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Mark.Rutland@arm.com Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30 October 2016 20:04:09 GMT+00:00, Brian Masney wrote: >On Sun, Oct 30, 2016 at 06:37:40PM +0000, Jonathan Cameron wrote: >> On 28/10/16 11:00, Brian Masney wrote: >> > The illuminance0_calibscale sysfs attribute is not currently >created by >> > the IIO core. This patch adds the appropriate mask to >iio_chan_spec, >> > along with the appropriate data handling in the read_raw() and >> > write_raw() functions, so that the sysfs attribute is created by >the IIO >> > core. With this change, this sysfs entry will have its prefix >changed >> > from illuminance0_ to in_illuminance_. >> > >> > Signed-off-by: Brian Masney >> Hmm. Could probably have computed the mean on the fly but fine as is. > >Hi Jonathan, > Thanks for your feedback. I'll have another patch set ready for you >by next weekend with my next round of cleanups to that driver. I'll >change this so that it calculates the mean on the fly unless I hear >otherwise from you. I don't worry about the mean change. Not worth changing to my mind. J > >Brian > >-- >To unsubscribe from this list: send the line "unsubscribe linux-iio" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec Date: Sun, 30 Oct 2016 20:29:07 +0000 Message-ID: References: <1477648821-3786-1-git-send-email-masneyb@onstation.org> <1477648821-3786-8-git-send-email-masneyb@onstation.org> <20161030200409.GA14808@basecamp.onstation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20161030200409.GA14808-+HJwobWzVoXN2ZRhSsNpr3G1qET/BF4J@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Masney , Jonathan Cameron Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Mark.Rutland-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org On 30 October 2016 20:04:09 GMT+00:00, Brian Masney wrote: >On Sun, Oct 30, 2016 at 06:37:40PM +0000, Jonathan Cameron wrote: >> On 28/10/16 11:00, Brian Masney wrote: >> > The illuminance0_calibscale sysfs attribute is not currently >created by >> > the IIO core. This patch adds the appropriate mask to >iio_chan_spec, >> > along with the appropriate data handling in the read_raw() and >> > write_raw() functions, so that the sysfs attribute is created by >the IIO >> > core. With this change, this sysfs entry will have its prefix >changed >> > from illuminance0_ to in_illuminance_. >> > >> > Signed-off-by: Brian Masney >> Hmm. Could probably have computed the mean on the fly but fine as is. > >Hi Jonathan, > Thanks for your feedback. I'll have another patch set ready for you >by next weekend with my next round of cleanups to that driver. I'll >change this so that it calculates the mean on the fly unless I hear >otherwise from you. I don't worry about the mean change. Not worth changing to my mind. J > >Brian > >-- >To unsubscribe from this list: send the line "unsubscribe linux-iio" in >the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sent from my Android device with K-9 Mail. Please excuse my brevity.