From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqq6u-0005B4-DH for qemu-devel@nongnu.org; Mon, 16 Jul 2012 14:33:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sqq6t-0002Gk-Co for qemu-devel@nongnu.org; Mon, 16 Jul 2012 14:33:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49833 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqq6t-0002Gg-5j for qemu-devel@nongnu.org; Mon, 16 Jul 2012 14:33:31 -0400 Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Alexander Graf In-Reply-To: Date: Mon, 16 Jul 2012 20:33:23 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <1342360440-14328-1-git-send-email-sw@weilnetz.de> <500434C8.6050200@redhat.com> <50044E56.8050408@suse.de> Subject: Re: [Qemu-devel] [PATCH] configure: Fix build with capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , Stefan Weil , Eric Blake , qemu-devel@nongnu.org On 16.07.2012, at 20:28, Peter Maydell wrote: > On 16 July 2012 18:24, Alexander Graf wrote: >> On 07/16/2012 05:40 PM, Peter Maydell wrote: >>> Hmm, good point -- unlike the actual program compile, failures >>> due to -Werror inside configure are silent and near-invisible. >>> Maybe we should back out 417c9d72 ? >> >> So how do we deal with the original problem then? The one where the build >> broke for me because the smartcard code got compiled in because configure >> didn't know that it would fail to compile with -Werror? > > We could have a specific configure check for "can you include > this header file in a -Werror compilation", I guess? That's what my first patch did. Alex