All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [BlueZ v4] monitor: Fix the incorrect vendor name
Date: Wed, 21 Apr 2021 10:14:36 +0200	[thread overview]
Message-ID: <AD3B62C3-F6FB-4D9D-BD31-3A9117828324@holtmann.org> (raw)
In-Reply-To: <20210421033758.762312-1-hj.tedd.an@gmail.com>

Hi Tedd,

> This patch fixes the vendor name is alwasy shown as "Microsoft" for the
> commands and Unknown name for vendor events.
> 
> < HCI Command: Microsoft Secure Send (0x3f|0x0009) plen 249
>        Type: Data fragment (0x01)
>> HCI Event: Command Complete (0x0e) plen 4
>      Microsoft Secure Send (0x3f|0x0009) ncmd 31
>        Status: Success (0x00)
> ---
> monitor/msft.h   |   6 +++
> monitor/packet.c | 131 ++++++++++++++++++++++++++++++++++++++---------
> 2 files changed, 113 insertions(+), 24 deletions(-)
> 
> diff --git a/monitor/msft.h b/monitor/msft.h
> index a268f4bc7..7573b5ba1 100644
> --- a/monitor/msft.h
> +++ b/monitor/msft.h
> @@ -24,6 +24,12 @@
> 
> #include <stdint.h>
> 
> +struct msft_ext {
> +	uint16_t opcode;
> +	uint8_t  evt_prefix_len;
> +	uint8_t  evt_prefix[32];
> +};
> +
> struct vendor_ocf;
> struct vendor_evt;
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index d729a01cc..6df96df48 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -265,7 +265,7 @@ struct index_data {
> 	uint8_t  type;
> 	uint8_t  bdaddr[6];
> 	uint16_t manufacturer;
> -	uint16_t msft_opcode;
> +	struct msft_ext msft_ext;

don’t bother with the struct, just add the extra needed variables right here.

Regards

Marcel


      parent reply	other threads:[~2021-04-21  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21  3:37 [BlueZ v4] monitor: Fix the incorrect vendor name Tedd Ho-Jeong An
2021-04-21  4:07 ` [BlueZ,v4] " bluez.test.bot
2021-04-21  8:14 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AD3B62C3-F6FB-4D9D-BD31-3A9117828324@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=hj.tedd.an@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.