From: Marcel Holtmann <marcel@holtmann.org>
To: Sathish Narsimman <nsathish41@gmail.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Chethan T N <chethan.tumkur.narayan@intel.com>,
Sathish Narsimman <sathish.narasimman@intel.com>
Subject: Re: [PATCH 1/7] Bluetooth: LL Privacy Delete Store Resolving list
Date: Wed, 18 Mar 2020 11:42:46 +0100 [thread overview]
Message-ID: <AD87C0E6-8A18-4016-9A4C-CE2934B6F862@holtmann.org> (raw)
In-Reply-To: <20200312100754.3445-2-sathish.narasimman@intel.com>
Hi Sathish,
> This patch help to delte the resolving list stored in the BT
> Controller w.r.t BD_ADDR.
>
> Signed-off-by: Sathish Narsimman <sathish.narasimman@intel.com>
> ---
> include/net/bluetooth/hci.h | 1 +
> include/net/bluetooth/hci_core.h | 2 ++
> net/bluetooth/hci_request.c | 33 ++++++++++++++++++++++++++++++++
> 3 files changed, 36 insertions(+)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 5f60e135aeb6..352bc43940ff 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -457,6 +457,7 @@ enum {
> #define HCI_LE_DATA_LEN_EXT 0x20
> #define HCI_LE_PHY_2M 0x01
> #define HCI_LE_PHY_CODED 0x08
> +#define HCI_LE_LL_PRIVACY 0x40
> #define HCI_LE_EXT_ADV 0x10
> #define HCI_LE_EXT_SCAN_POLICY 0x80
> #define HCI_LE_PHY_2M 0x01
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index d4e28773d378..5f04ef88da35 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -1657,6 +1657,8 @@ void hci_le_start_enc(struct hci_conn *conn, __le16 ediv, __le64 rand,
>
> void hci_copy_identity_address(struct hci_dev *hdev, bdaddr_t *bdaddr,
> u8 *bdaddr_type);
> +void hci_req_del_from_resolving_list(struct hci_dev *hdev, u8 addr_type,
> + bdaddr_t *bdaddr);
>
> #define SCO_AIRMODE_MASK 0x0003
> #define SCO_AIRMODE_CVSD 0x0000
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index bf83179ab9d1..f4bbd3b79210 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -885,6 +885,39 @@ static void hci_req_start_scan(struct hci_request *req, u8 type, u16 interval,
> }
> }
>
> +void hci_req_del_from_resolving_list(struct hci_dev *hdev, u8 addr_type, bdaddr_t *bdaddr)
> +{
> + struct hci_cp_le_del_from_resolv_list cp;
> + struct hci_request req;
> + struct bdaddr_list_with_irk *irk;
> +
> + BT_DBG("");
> +
> + /* Nothing to be done if LL privacy is not supported */
> + if ( !(hdev->le_features[0] & HCI_LE_LL_PRIVACY) )
> + return;
> +
> + if ( !hci_dev_test_flag(hdev, HCI_LL_RPA_RESOLUTION) &&
> + ( hci_dev_test_flag(hdev, HCI_LE_ADV) ||
> + hci_dev_test_flag(hdev, HCI_LE_SCAN) ||
> + hci_lookup_le_connect(hdev) ) )
> + return;
please don’t invent your own coding style. Follow the netdev convention.
Regards
Marcel
next prev parent reply other threads:[~2020-03-18 10:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 10:07 [PATCH 0/7] LE LL Priavcy support enabled Sathish Narsimman
2020-03-12 10:07 ` [PATCH 1/7] Bluetooth: LL Privacy Delete Store Resolving list Sathish Narsimman
2020-03-18 10:42 ` Marcel Holtmann [this message]
2020-03-18 10:47 ` Sathish Narasimman
2020-03-12 10:07 ` [PATCH 2/7] Bluetooth: Add device to Resolving List Sathish Narsimman
2020-03-18 9:29 ` Szymon Janc
2020-03-18 10:29 ` Sathish Narasimman
2020-03-12 10:07 ` [PATCH 3/7] Bluetooth: Update the Resolving list when Local IRK changed Sathish Narsimman
2020-03-18 10:45 ` Marcel Holtmann
2020-03-12 10:07 ` [PATCH 4/7] Bluetooth: LL_PRIVACY re-load resolving list Sathish Narsimman
2020-03-18 11:06 ` Marcel Holtmann
2020-03-12 10:07 ` [PATCH 5/7] Bluetooth: LL Privacy Check and Update the Resolving List Sathish Narsimman
2020-03-12 10:07 ` [PATCH 6/7] Bluetooth: Enable LL Privacy Sathish Narsimman
2020-03-18 11:04 ` Marcel Holtmann
2020-03-12 10:07 ` [PATCH 7/7] Bluetooth LL Privacy update White list Sathish Narsimman
2020-03-12 22:02 ` kbuild test robot
2020-03-12 23:23 ` kbuild test robot
2020-03-12 23:44 ` kbuild test robot
2020-03-18 8:56 ` [PATCH 0/7] LE LL Priavcy support enabled Sathish Narasimman
2020-04-01 20:04 ` Abhishek Pandit-Subedi
2020-04-06 16:34 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AD87C0E6-8A18-4016-9A4C-CE2934B6F862@holtmann.org \
--to=marcel@holtmann.org \
--cc=chethan.tumkur.narayan@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=nsathish41@gmail.com \
--cc=sathish.narasimman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.