From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [RFC PATCH 4/5] arm64: smp: move the pen to a header file Date: Tue, 14 Apr 2015 14:41:13 -0500 Message-ID: References: <1428601031-5366-1-git-send-email-galak@codeaurora.org> <1428601031-5366-5-git-send-email-galak@codeaurora.org> <6018110.XP6YK3PMra@wuerfel> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6018110.XP6YK3PMra@wuerfel> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-msm@vger.kernel.org, Abhimanyu Kapur , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com List-Id: linux-arm-msm@vger.kernel.org > On Apr 9, 2015, at 4:17 PM, Arnd Bergmann wrote: > > On Thursday 09 April 2015 12:37:10 Kumar Gala wrote: >> From: Abhimanyu Kapur >> >> Move the secondary_pen_release variable and the secondary_holding_pen >> entry function to asm/smp_plat.h so that the other cpu ops implementations >> can share them. >> >> Signed-off-by: Abhimanyu Kapur >> Signed-off-by: Kumar Gala >> > > I don't believe your SMP implementation can be so broken to require this. > Please fix the code instead to not use a holding pen. > > Arnd Yeah, I can drop this. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: galak@codeaurora.org (Kumar Gala) Date: Tue, 14 Apr 2015 14:41:13 -0500 Subject: [RFC PATCH 4/5] arm64: smp: move the pen to a header file In-Reply-To: <6018110.XP6YK3PMra@wuerfel> References: <1428601031-5366-1-git-send-email-galak@codeaurora.org> <1428601031-5366-5-git-send-email-galak@codeaurora.org> <6018110.XP6YK3PMra@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > On Apr 9, 2015, at 4:17 PM, Arnd Bergmann wrote: > > On Thursday 09 April 2015 12:37:10 Kumar Gala wrote: >> From: Abhimanyu Kapur >> >> Move the secondary_pen_release variable and the secondary_holding_pen >> entry function to asm/smp_plat.h so that the other cpu ops implementations >> can share them. >> >> Signed-off-by: Abhimanyu Kapur >> Signed-off-by: Kumar Gala >> > > I don't believe your SMP implementation can be so broken to require this. > Please fix the code instead to not use a holding pen. > > Arnd Yeah, I can drop this. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project