From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook From: Paolo Valente In-Reply-To: <1518001397.29698.6.camel@gmx.de> Date: Wed, 7 Feb 2018 12:12:18 +0100 Cc: Oleksandr Natalenko , Jens Axboe , linux-block , Linux Kernel Mailing List , Ulf Hansson , Mark Brown , Linus Walleij , 'Paolo Valente' via bfq-iosched , Alban Browaeys , Ming Lei , Ivan Kozik , SERENA ZIVIANI <169364@studenti.unimore.it>, Serena Ziviani , =?utf-8?Q?Holger_Hoffst=C3=A4tte?= Message-Id: References: <20180205190510.5499-1-paolo.valente@linaro.org> <20180205190510.5499-2-paolo.valente@linaro.org> <1517903761.9843.12.camel@gmx.de> <899B68CC-5955-4418-8BFF-DC55A743A61B@linaro.org> <1517918234.25841.31.camel@gmx.de> <77124223e6116350a5184a5199850304@natalenko.name> <1517924768.25841.32.camel@gmx.de> <8842084cc8a26b7f46ae600bda8a7bd0@natalenko.name> <82ffc96aacc3945861cbb708df346338@natalenko.name> <1517995431.25619.5.camel@gmx.de> <1517998516.6606.1.camel@gmx.de> <5584030F-8F4E-4C98-84A5-79873A1BF775@linaro.org> <1518001397.29698.6.camel@gmx.de> To: Mike Galbraith List-ID: > Il giorno 07 feb 2018, alle ore 12:03, Mike Galbraith = ha scritto: >=20 > On Wed, 2018-02-07 at 11:27 +0100, Paolo Valente wrote: >>=20 >> 2. Could you please turn that BUG_ON into: >> if (!(rq->rq_flags & RQF_ELVPRIV)) >> return; >> and see what happens? >=20 > That seems to make it forgets how to make boom. >=20 Great! This deserves to be celebrated with a packet of Ikea chips. Just to be certain, before submitting a new patch: you changed *only* the BUG_ON at line 4742, on top of my instrumentation patch. Thanks, Paolo > -Mike From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753745AbeBGLMY (ORCPT ); Wed, 7 Feb 2018 06:12:24 -0500 Received: from mail-wr0-f179.google.com ([209.85.128.179]:43679 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753454AbeBGLMW (ORCPT ); Wed, 7 Feb 2018 06:12:22 -0500 X-Google-Smtp-Source: AH8x227ajZXLNfNUlr8hvMA0RG9SCPeMkSkezHYDtSGlSCJVCGpWh4AbhgehkQrse9r7gmEjpPSIgA== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook From: Paolo Valente In-Reply-To: <1518001397.29698.6.camel@gmx.de> Date: Wed, 7 Feb 2018 12:12:18 +0100 Cc: Oleksandr Natalenko , Jens Axboe , linux-block , Linux Kernel Mailing List , Ulf Hansson , Mark Brown , Linus Walleij , "'Paolo Valente' via bfq-iosched" , Alban Browaeys , Ming Lei , Ivan Kozik , SERENA ZIVIANI <169364@studenti.unimore.it>, Serena Ziviani , =?utf-8?Q?Holger_Hoffst=C3=A4tte?= Message-Id: References: <20180205190510.5499-1-paolo.valente@linaro.org> <20180205190510.5499-2-paolo.valente@linaro.org> <1517903761.9843.12.camel@gmx.de> <899B68CC-5955-4418-8BFF-DC55A743A61B@linaro.org> <1517918234.25841.31.camel@gmx.de> <77124223e6116350a5184a5199850304@natalenko.name> <1517924768.25841.32.camel@gmx.de> <8842084cc8a26b7f46ae600bda8a7bd0@natalenko.name> <82ffc96aacc3945861cbb708df346338@natalenko.name> <1517995431.25619.5.camel@gmx.de> <1517998516.6606.1.camel@gmx.de> <5584030F-8F4E-4C98-84A5-79873A1BF775@linaro.org> <1518001397.29698.6.camel@gmx.de> To: Mike Galbraith X-Mailer: Apple Mail (2.3445.5.20) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w17BCTd9013438 > Il giorno 07 feb 2018, alle ore 12:03, Mike Galbraith ha scritto: > > On Wed, 2018-02-07 at 11:27 +0100, Paolo Valente wrote: >> >> 2. Could you please turn that BUG_ON into: >> if (!(rq->rq_flags & RQF_ELVPRIV)) >> return; >> and see what happens? > > That seems to make it forgets how to make boom. > Great! This deserves to be celebrated with a packet of Ikea chips. Just to be certain, before submitting a new patch: you changed *only* the BUG_ON at line 4742, on top of my instrumentation patch. Thanks, Paolo > -Mike