From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [PATCH v2 04/18] eal: add lightweight kvarg parsing utility Date: Wed, 21 Mar 2018 17:32:24 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Gaetan Rivet Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 264A34CC7 for ; Wed, 21 Mar 2018 18:32:26 +0100 (CET) In-Reply-To: Content-Language: en-US Content-ID: <59BE2DBB0B3A1F4481F6B3BD16F123EE@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Mar 21, 2018, at 12:15 PM, Gaetan Rivet wrote= : >=20 > This library offers a quick way to parse parameters passed with a > key=3Dvalue syntax. >=20 > A single function is needed and finds the relevant element within the > text. No dynamic allocation is performed. It is possible to chain the > parsing of each pairs for quickly scanning a list. >=20 > This utility is private to the EAL and should allow avoiding having to > move around the more complete librte_kvargs. What is the big advantage with this code and the librte_kvargs code. Is it = just no allocation, rte_kvargs needs to be build before parts of EAL or wha= t? My concern is we have now two flavors one in EAL and one in librte_kvargs, = would it not be more reasonable to improve rte_kvargs to remove your object= ions? I am all for fast, better, stronger code :-) >=20 > Signed-off-by: Gaetan Rivet Regards, Keith