All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Song, Hongyan" <hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Bastien Nocera <hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>,
	"linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Pandruvada,
	Srinivas"
	<srinivas.pandruvada-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: RE: [PATCH] iio: hid: hid-sensor-accel-3d: Add second ACC sensor support
Date: Fri, 17 Mar 2017 01:21:29 +0000	[thread overview]
Message-ID: <AE3E3DFA698D6144A7445C92D1D41E2F10BE185E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1489665702.18490.12.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>

Hi,
	Thanks for your comments. But I am not sure what your "type" mean.
If you mean "sensor type", I expose it as second ACC, the sensor type is the same with the exist ACC,
It cannot be used as a distinction.
If you mean the "connection type" I used in the patch, "connection type" is only defined in HID driver,
It is not a common property in IIO. So not good to expose it out.


BR
Song Hongyan  

-----Original Message-----
From: Bastien Nocera [mailto:hadess@hadess.net] 
Sent: Thursday, March 16, 2017 8:02 PM
To: Song, Hongyan <hongyan.song@intel.com>; linux-input@vger.kernel.org; linux-iio@vger.kernel.org
Cc: jikos@kernel.org; jic23@kernel.org; Pandruvada, Srinivas <srinivas.pandruvada@intel.com>
Subject: Re: [PATCH] iio: hid: hid-sensor-accel-3d: Add second ACC sensor support

On Thu, 2017-03-16 at 18:20 +0800, Song Hongyan wrote:
> As accelerometer sensor becomes more and more popular, there are more 
> user scenarios have been developed, "Hinge" is a very important 
> usecase which needs two accelerometer sensors to calculate the 
> included angle of keyboard and screen.
> In this case, two accelerometer sensors will be exposed. Currently, 
> IIO interface hasn't other way to distinguish two sensors with same 
> sensor type, except sensor name. So a new sensor name "accel_2nd_3d"
> is added for secondary accelerometer sensor.
> 
> In HID level, connection type is a good common property to 
> differentiate two sensors with same sensor type.

I've been told in the past not to rely on device names in iio-sensor- proxy, and this would go against this advice.

As you have a "type" to export, why not export that instead?

WARNING: multiple messages have this Message-ID
From: "Song, Hongyan" <hongyan.song@intel.com>
To: Bastien Nocera <hadess@hadess.net>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "jikos@kernel.org" <jikos@kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
Subject: RE: [PATCH] iio: hid: hid-sensor-accel-3d: Add second ACC sensor support
Date: Fri, 17 Mar 2017 01:21:29 +0000	[thread overview]
Message-ID: <AE3E3DFA698D6144A7445C92D1D41E2F10BE185E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1489665702.18490.12.camel@hadess.net>

SGksDQoJVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzLiBCdXQgSSBhbSBub3Qgc3VyZSB3aGF0IHlv
dXIgInR5cGUiIG1lYW4uDQpJZiB5b3UgbWVhbiAic2Vuc29yIHR5cGUiLCBJIGV4cG9zZSBpdCBh
cyBzZWNvbmQgQUNDLCB0aGUgc2Vuc29yIHR5cGUgaXMgdGhlIHNhbWUgd2l0aCB0aGUgZXhpc3Qg
QUNDLA0KSXQgY2Fubm90IGJlIHVzZWQgYXMgYSBkaXN0aW5jdGlvbi4NCklmIHlvdSBtZWFuIHRo
ZSAiY29ubmVjdGlvbiB0eXBlIiBJIHVzZWQgaW4gdGhlIHBhdGNoLCAiY29ubmVjdGlvbiB0eXBl
IiBpcyBvbmx5IGRlZmluZWQgaW4gSElEIGRyaXZlciwNCkl0IGlzIG5vdCBhIGNvbW1vbiBwcm9w
ZXJ0eSBpbiBJSU8uIFNvIG5vdCBnb29kIHRvIGV4cG9zZSBpdCBvdXQuDQoNCg0KQlINClNvbmcg
SG9uZ3lhbiAgDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBCYXN0aWVuIE5v
Y2VyYSBbbWFpbHRvOmhhZGVzc0BoYWRlc3MubmV0XSANClNlbnQ6IFRodXJzZGF5LCBNYXJjaCAx
NiwgMjAxNyA4OjAyIFBNDQpUbzogU29uZywgSG9uZ3lhbiA8aG9uZ3lhbi5zb25nQGludGVsLmNv
bT47IGxpbnV4LWlucHV0QHZnZXIua2VybmVsLm9yZzsgbGludXgtaWlvQHZnZXIua2VybmVsLm9y
Zw0KQ2M6IGppa29zQGtlcm5lbC5vcmc7IGppYzIzQGtlcm5lbC5vcmc7IFBhbmRydXZhZGEsIFNy
aW5pdmFzIDxzcmluaXZhcy5wYW5kcnV2YWRhQGludGVsLmNvbT4NClN1YmplY3Q6IFJlOiBbUEFU
Q0hdIGlpbzogaGlkOiBoaWQtc2Vuc29yLWFjY2VsLTNkOiBBZGQgc2Vjb25kIEFDQyBzZW5zb3Ig
c3VwcG9ydA0KDQpPbiBUaHUsIDIwMTctMDMtMTYgYXQgMTg6MjAgKzA4MDAsIFNvbmcgSG9uZ3lh
biB3cm90ZToNCj4gQXMgYWNjZWxlcm9tZXRlciBzZW5zb3IgYmVjb21lcyBtb3JlIGFuZCBtb3Jl
IHBvcHVsYXIsIHRoZXJlIGFyZSBtb3JlIA0KPiB1c2VyIHNjZW5hcmlvcyBoYXZlIGJlZW4gZGV2
ZWxvcGVkLCAiSGluZ2UiIGlzIGEgdmVyeSBpbXBvcnRhbnQgDQo+IHVzZWNhc2Ugd2hpY2ggbmVl
ZHMgdHdvIGFjY2VsZXJvbWV0ZXIgc2Vuc29ycyB0byBjYWxjdWxhdGUgdGhlIA0KPiBpbmNsdWRl
ZCBhbmdsZSBvZiBrZXlib2FyZCBhbmQgc2NyZWVuLg0KPiBJbiB0aGlzIGNhc2UsIHR3byBhY2Nl
bGVyb21ldGVyIHNlbnNvcnMgd2lsbCBiZSBleHBvc2VkLiBDdXJyZW50bHksIA0KPiBJSU8gaW50
ZXJmYWNlIGhhc24ndCBvdGhlciB3YXkgdG8gZGlzdGluZ3Vpc2ggdHdvIHNlbnNvcnMgd2l0aCBz
YW1lIA0KPiBzZW5zb3IgdHlwZSwgZXhjZXB0IHNlbnNvciBuYW1lLiBTbyBhIG5ldyBzZW5zb3Ig
bmFtZSAiYWNjZWxfMm5kXzNkIg0KPiBpcyBhZGRlZCBmb3Igc2Vjb25kYXJ5IGFjY2VsZXJvbWV0
ZXIgc2Vuc29yLg0KPiANCj4gSW4gSElEIGxldmVsLCBjb25uZWN0aW9uIHR5cGUgaXMgYSBnb29k
IGNvbW1vbiBwcm9wZXJ0eSB0byANCj4gZGlmZmVyZW50aWF0ZSB0d28gc2Vuc29ycyB3aXRoIHNh
bWUgc2Vuc29yIHR5cGUuDQoNCkkndmUgYmVlbiB0b2xkIGluIHRoZSBwYXN0IG5vdCB0byByZWx5
IG9uIGRldmljZSBuYW1lcyBpbiBpaW8tc2Vuc29yLSBwcm94eSwgYW5kIHRoaXMgd291bGQgZ28g
YWdhaW5zdCB0aGlzIGFkdmljZS4NCg0KQXMgeW91IGhhdmUgYSAidHlwZSIgdG8gZXhwb3J0LCB3
aHkgbm90IGV4cG9ydCB0aGF0IGluc3RlYWQ/DQo=

  parent reply	other threads:[~2017-03-17  1:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16 10:20 Song Hongyan
2017-03-16 10:20 ` Song Hongyan
2017-03-16 12:01 ` Bastien Nocera
     [not found]   ` <1489665702.18490.12.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>
2017-03-17  1:21     ` Song, Hongyan [this message]
2017-03-17  1:21       ` Song, Hongyan
2017-03-17 13:14       ` Bastien Nocera
     [not found] ` <1489659652-35608-1-git-send-email-hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-03-17  2:13   ` Pandruvada, Srinivas
2017-03-17  2:13     ` Pandruvada, Srinivas
2017-03-17 13:16     ` Bastien Nocera
     [not found]       ` <1489756594.18490.22.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>
2017-03-17 13:31         ` Jonathan Cameron
2017-03-17 13:31           ` Jonathan Cameron
2017-03-17 16:22       ` Pandruvada, Srinivas
2017-03-17 16:22         ` Pandruvada, Srinivas
2017-03-18  0:24         ` Milton Mobley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AE3E3DFA698D6144A7445C92D1D41E2F10BE185E@SHSMSX103.ccr.corp.intel.com \
    --to=hongyan.song-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=srinivas.pandruvada-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --subject='RE: [PATCH] iio: hid: hid-sensor-accel-3d: Add second ACC sensor support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.