All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rafael Gieschke <rafael@gieschke.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCHv2] add Android support
Date: Thu, 19 May 2011 19:30:49 +0200	[thread overview]
Message-ID: <AE42113D-8D2F-4B24-A800-D49183152911@gieschke.de> (raw)
In-Reply-To: <20110519122026.GA30240@sigill.intra.peff.net>


Am 19.05.2011 um 14:20 schrieb Jeff King:

> The point of uname_S is that it would be found automatically. Sadly,
> There is nothing helpful in uname to tell us that we are on android:
> 

Actually, you can't even call uname as I suspect that you would normally not compile on Android (I don't think that gcc runs on Android) but always cross-compile.


> So I think we are probably stuck either with the user setting an ANDROID
> meta-flag that sets the other flags appropriately, or leaving it up to
> the user to provide a sane config.mak.

Yes, I agree that leaving it up completely to the user to provide a config.mak is a very good option too, especially as build environments might be different and some might want to try building with Perl and libcurl, which would require a config.mak anyhow.

  reply	other threads:[~2011-05-19 17:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 23:23 [PATCHv2] add Android support Rafael Gieschke
2011-05-19  6:18 ` Junio C Hamano
2011-05-19 11:37   ` Rafael Gieschke
2011-05-19 12:20     ` Jeff King
2011-05-19 17:30       ` Rafael Gieschke [this message]
2011-05-19 17:38         ` Jeff King
2011-05-19 19:27           ` Rafael Gieschke
2011-05-23  7:04       ` Cross-compiling git (was: [PATCHv2] add Android support) Jakub Narebski
2011-05-23 14:30         ` Jeff King
2011-05-25 14:20           ` Jakub Narebski
2011-05-25 15:06             ` Jeff King
2011-05-19 14:17     ` [PATCHv2] add Android support Junio C Hamano
2011-05-23  8:01   ` Tor Arntsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AE42113D-8D2F-4B24-A800-D49183152911@gieschke.de \
    --to=rafael@gieschke.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.