From: "David Laight" <David.Laight@ACULAB.COM>
To: "Pavel Emelyanov" <xemul@parallels.com>,
"David Miller" <davem@davemloft.net>,
"Linux Netdev List" <netdev@vger.kernel.org>
Subject: RE: [PATCH] tcp repair: Fix unaligned access when repairing options
Date: Wed, 25 Apr 2012 15:11:30 +0100 [thread overview]
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6EF2@saturn3.aculab.com> (raw)
In-Reply-To: <4F97EFA9.2080903@parallels.com>
> +struct tcp_repair_opt {
> + __u8 opt_code;
> + __u16 opt_val;
> +};
That structure has an implied pad field, probably best to
either make it explicit or change the types.
I'd have thought it would do no harm to use two __u32 fields
(unless you really need to save memory somewhere).
David
next prev parent reply other threads:[~2012-04-25 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 12:35 [PATCH] tcp repair: Fix unaligned access when repairing options Pavel Emelyanov
2012-04-25 14:11 ` David Laight [this message]
2012-04-25 18:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE90C24D6B3A694183C094C60CF0A2F6026B6EF2@saturn3.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.