From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757490Ab3FCMsL (ORCPT ); Mon, 3 Jun 2013 08:48:11 -0400 Received: from mx0.aculab.com ([213.249.233.131]:60820 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755912Ab3FCMsJ (ORCPT ); Mon, 3 Jun 2013 08:48:09 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Subject: RE: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U' Date: Mon, 3 Jun 2013 13:47:24 +0100 Message-ID: In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U' Thread-Index: Ac5gTP47znuaL0AITMyRQ3C0h7fPxgACE3hgAADCULA= References: <51A6EBC5.7040601@asianux.com> <51AC60AA.8010107@asianux.com> <51AC7546.4010002@asianux.com> <51AC7CD4.2060801@asianux.com> From: "David Laight" To: "David Laight" , "Chen Gang" , "Andy Shevchenko" , Cc: "Pravin Shelar" , , "David Miller" , "Andrew Morton" , , "netdev" , "Ben Hutchings" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r53CmIMj007266 > > +#define SKB_HEADER_UNSET_16 ((unsigned short) ~0U) > > + > > The _16 part isn't really correct, the type could be changed > and then it would be wrong. > > I think I might have used SKB_HEADER_OFFSET. I meant SKB_HEADER_UNSET_OFFSET or SKB_HEADER_OFFSET_UNSET > NrybXǧv^)޺{.n+z^)w*jgݢj/zޖ2ޙ&)ߡaGhj:+vw٥ I've NFI what adds this! David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David Laight" Subject: RE: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U' Date: Mon, 3 Jun 2013 13:47:24 +0100 Message-ID: References: <51A6EBC5.7040601@asianux.com> <51AC60AA.8010107@asianux.com> <51AC7546.4010002@asianux.com> <51AC7CD4.2060801@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "Pravin Shelar" , , "David Miller" , "Andrew Morton" , , "netdev" , "Ben Hutchings" To: "David Laight" , "Chen Gang" , "Andy Shevchenko" , Return-path: Content-class: urn:content-classes:message In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org PiA+ICsjZGVmaW5lIFNLQl9IRUFERVJfVU5TRVRfMTYJKCh1bnNpZ25lZCBzaG9ydCkgfjBVKQ0K PiA+ICsNCj4gDQo+IFRoZSBfMTYgcGFydCBpc24ndCByZWFsbHkgY29ycmVjdCwgdGhlIHR5cGUg Y291bGQgYmUgY2hhbmdlZA0KPiBhbmQgdGhlbiBpdCB3b3VsZCBiZSB3cm9uZy4NCj4gDQo+IEkg dGhpbmsgSSBtaWdodCBoYXZlIHVzZWQgU0tCX0hFQURFUl9PRkZTRVQuDQoNCkkgbWVhbnQgU0tC X0hFQURFUl9VTlNFVF9PRkZTRVQgb3IgU0tCX0hFQURFUl9PRkZTRVRfVU5TRVQNCg0KPiBOcnli WMendl4p3rp7Lm4rel4pdypqZx7domovet6WMt6ZJinfoWF/HkdoD2o6K3Z32aUNCg0KSSd2ZSBO Rkkgd2hhdCBhZGRzIHRoaXMhDQoNCglEYXZpZA0KDQo=