From mboxrd@z Thu Jan  1 00:00:00 1970
From: "James Harper" <james.harper@bendigoit.com.au>
Subject: AMD crash on restore. bug in MTRR restore. 4.0.2-rc2-pre
Date: Wed, 26 Jan 2011 17:18:50 +1100
Message-ID: <AEC6C66638C05B468B556EA548C1A77D01BB928D@trantor>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-class: urn:content-classes:message
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Tim Deegan <Tim.Deegan@citrix.com>
List-Id: xen-devel@lists.xenproject.org

The mtrr save code on my AMD system reads the first MTRR as
0x00000000f0000000,0x000000fff8000800. When it tries to restore in
mtrr_var_range_msr_set, 0x000000fff8000800 is rejected as invalid and
not restored.

Commenting out the check against the mask, as well as Tim's patch to fix
the segment registers makes the output of xen-hvmctx match before the
save and after the restore.

Windows still crashes on restore though so I don't know if this has
anything to do with it.

James