All of lore.kernel.org
 help / color / mirror / Atom feed
From: "James Harper" <james.harper@bendigoit.com.au>
To: xen-devel@lists.xensource.com
Cc: Tim Deegan <Tim.Deegan@citrix.com>
Subject: RE: AMD crash on restore. bug in MTRR restore.4.0.2-rc2-pre
Date: Thu, 27 Jan 2011 14:49:48 +1100	[thread overview]
Message-ID: <AEC6C66638C05B468B556EA548C1A77D01BB92B3@trantor> (raw)
In-Reply-To: <AEC6C66638C05B468B556EA548C1A77D01BB92AD@trantor>

By saving the sysenter msrs in my PV drivers before the suspend
hypercall and restoring them after, save/restore now works fine.

Does nobody else see a save/restore failure on AMD as a blocker to
4.0.2? It it something particular to my exact AMD CPU and OS (Windows
2008 x32)?

James

> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-
> bounces@lists.xensource.com] On Behalf Of James Harper
> Sent: Thursday, 27 January 2011 13:32
> To: xen-devel@lists.xensource.com
> Cc: Tim Deegan
> Subject: RE: [Xen-devel] AMD crash on restore. bug in MTRR
restore.4.0.2-rc2-
> pre
> 
> Additionally, WinDbg tells me that MSR's 175, and 176 are wiped out by
> save/restore:
> 
> immediately before suspend
> kd> rdmsr 174
> msr[174] = 00000000`00000008
> kd> rdmsr 175
> msr[175] = 00000000`8039e000
> kd> rdmsr 176
> msr[176] = 00000000`816a4950
> 
> immediately after restore
> kd> rdmsr 174
> msr[174] = 00000000`00000000
> kd> rdmsr 175
> msr[175] = 00000000`00000000
> kd> rdmsr 176
> msr[176] = 00000000`00000000
> 
> although you're never too sure with WinDbg...
> 
> James
> 
> > -----Original Message-----
> > From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-
> > bounces@lists.xensource.com] On Behalf Of James Harper
> > Sent: Wednesday, 26 January 2011 17:19
> > To: xen-devel@lists.xensource.com
> > Cc: Tim Deegan
> > Subject: [Xen-devel] AMD crash on restore. bug in MTRR restore.
> 4.0.2-rc2-pre
> >
> > The mtrr save code on my AMD system reads the first MTRR as
> > 0x00000000f0000000,0x000000fff8000800. When it tries to restore in
> > mtrr_var_range_msr_set, 0x000000fff8000800 is rejected as invalid
and
> > not restored.
> >
> > Commenting out the check against the mask, as well as Tim's patch to
> fix
> > the segment registers makes the output of xen-hvmctx match before
the
> > save and after the restore.
> >
> > Windows still crashes on restore though so I don't know if this has
> > anything to do with it.
> >
> > James
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

  reply	other threads:[~2011-01-27  3:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  6:18 AMD crash on restore. bug in MTRR restore. 4.0.2-rc2-pre James Harper
2011-01-27  2:31 ` James Harper
2011-01-27  3:49   ` James Harper [this message]
2011-01-27  8:51     ` AMD crash on restore. bug in MTRR restore.4.0.2-rc2-pre Jan Beulich
2011-01-29  6:39     ` Wei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AEC6C66638C05B468B556EA548C1A77D01BB92B3@trantor \
    --to=james.harper@bendigoit.com.au \
    --cc=Tim.Deegan@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.