All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guy Harris <guy@alum.mit.edu>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, arnd@arndb.de
Subject: Re: AF_PACKET mmap() v4...
Date: Thu, 5 Nov 2015 00:14:51 -0800	[thread overview]
Message-ID: <AECBA5BB-2284-4C1E-ADCC-09B730D6EF9A@alum.mit.edu> (raw)
In-Reply-To: <20151105.000414.1682124328670738318.davem@davemloft.net>


On Nov 4, 2015, at 9:04 PM, David Miller <davem@davemloft.net> wrote:

> As part of fixing y2038 problems, Arnd is going to have to make a new
> version fo the AF_PACKET mmap() tpacker descriptors in order to extend
> the time values to 64-bit.
> 
> So I want everyone to think about whether there are any other changes
> we might want to make given that we have to make a v4 anyways.
> 
> Particularly, I am rather certain that the buffer management could be
> improved.  Some have complained that v3 is kinda awkward to use and/or
> suboptimal is various ways.

As a core libpcap developer, I will at least state that it works a *lot* better than v1 and v2 did.  Having buffer slots that can hold only one packet is *really* suboptimal for packet capture; having buffer slots that can hold multiple packets works a lot better, as there's less wasted memory.

I'll see whether there are any changes that *would* make libpcap's life better.

  parent reply	other threads:[~2015-11-05  8:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  5:04 AF_PACKET mmap() v4 David Miller
2015-11-05  6:53 ` Richard Cochran
2015-11-05  8:14 ` Guy Harris [this message]
2015-11-05 15:32   ` David Miller
2015-11-05  9:07 ` Arnd Bergmann
2015-11-05  9:39   ` Daniel Borkmann
2015-11-05 11:38     ` Eric Dumazet
2015-11-05 12:56       ` Daniel Borkmann
2015-11-05 16:17         ` Eric Dumazet
2015-11-05 22:56           ` Daniel Borkmann
2015-11-06 11:34             ` Daniel Borkmann
2015-11-08  2:19     ` Alexei Starovoitov
2015-11-08  4:27       ` John Fastabend
2015-11-09 10:54         ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AECBA5BB-2284-4C1E-ADCC-09B730D6EF9A@alum.mit.edu \
    --to=guy@alum.mit.edu \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.