From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756204Ab0JURwV (ORCPT ); Thu, 21 Oct 2010 13:52:21 -0400 Received: from idcmail-mo2no.shaw.ca ([64.59.134.9]:15727 "EHLO idcmail-mo2no.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756047Ab0JURwT convert rfc822-to-8bit (ORCPT ); Thu, 21 Oct 2010 13:52:19 -0400 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=cUTwMia+6fMZF7bjUHU44PO5dfBASsAn9IQPzcMrg/g= c=1 sm=1 a=QT8drYoAYEQA:10 a=BLceEmwcHowA:10 a=kj9zAlcOel0A:10 a=xqWC_Br6kY4A:10 a=c23vf5CSMVc0QQz9B4a6RA==:17 a=0EuGTOPUOMYycOhixQ4A:9 a=cEK2MmWAv6YktlrWYhUA:7 a=TOs814xW77Blr3J1qNk2C6POT9MA:4 a=CjuIK1q_8ugA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Subject: Re: [PATCH v2 20/22] bitops: remove ext2 non-atomic bitops from asm/bitops.h Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Andreas Dilger In-Reply-To: <1287672077-5797-21-git-send-email-akinobu.mita@gmail.com> Date: Thu, 21 Oct 2010 11:52:15 -0600 Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Christoph Hellwig , Andrew Morton , Jan Kara , linux-ext4@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1287672077-5797-1-git-send-email-akinobu.mita@gmail.com> <1287672077-5797-21-git-send-email-akinobu.mita@gmail.com> To: Akinobu Mita X-Mailer: Apple Mail (2.1081) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2010-10-21, at 08:41, Akinobu Mita wrote: > As the result of conversions, there are no users of ext2 non-atomic bit > operations except for ext2 file system itself. Now we can put them > into architecture independent code in ext2 file system, and remove > from asm/bitops.h for all architectures. Presumably there will be a separate patch series to remove the atomic ext2 bitops? I was going to suggest removing the ext2 comment in bitops.h, but I notice that there are still the atomic bitops left. In any case, thanks for your efforts. I agree that these ext2_* functions have no place in the generic code, and are only there for historical reasons. > --- a/arch/arm/include/asm/bitops.h > +++ b/arch/arm/include/asm/bitops.h > @@ -327,22 +327,10 @@ static inline int fls(int x) > * Ext2 is defined to use little-endian byte ordering. > * These do not need to be atomic. > */ > -#define ext2_set_bit(nr,p) \ > - __test_and_set_le_bit(nr, (unsigned long *)(p)) > #define ext2_set_bit_atomic(lock,nr,p) \ > test_and_set_le_bit(nr, (unsigned long *)(p)) > -#define ext2_clear_bit(nr,p) \ > - __test_and_clear_le_bit(nr, (unsigned long *)(p)) > #define ext2_clear_bit_atomic(lock,nr,p) \ > test_and_clear_le_bit(nr, (unsigned long *)(p)) > -#define ext2_test_bit(nr,p) \ > - test_le_bit(nr, (unsigned long *)(p)) > -#define ext2_find_first_zero_bit(p,sz) \ > - find_first_zero_le_bit((unsigned long *)(p), sz) > -#define ext2_find_next_zero_bit(p,sz,off) \ > - find_next_zero_le_bit((unsigned long *)(p), sz, off) > -#define ext2_find_next_bit(p, sz, off) \ > - find_next_le_bit((unsigned long *)(p), sz, off) Cheers, Andreas