From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8612C4338F for ; Sat, 14 Aug 2021 02:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C80A26103A for ; Sat, 14 Aug 2021 02:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236493AbhHNCI5 (ORCPT ); Fri, 13 Aug 2021 22:08:57 -0400 Received: from mail-m176236.qiye.163.com ([59.111.176.236]:22170 "EHLO mail-m176236.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236327AbhHNCIz (ORCPT ); Fri, 13 Aug 2021 22:08:55 -0400 Received: from vivo.com (localhost [127.0.0.1]) by mail-m176236.qiye.163.com (Hmail) with ESMTP id 81E3078009F; Sat, 14 Aug 2021 10:08:25 +0800 (CST) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Message-ID: To: Chao Yu Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: =?UTF-8?B?UmU6UmU6IFtQQVRDSCB2NSAxLzJdIGYyZnM6IGludHJvZHVjZSBwcm9jL2ZzL2YyZnMvPGRldj4vZnNja19zdGFjayBub2Rl?= X-Priority: 3 X-Mailer: HMail Webmail Server V2.0 Copyright (c) 2016-163.com X-Originating-IP: 58.251.74.231 In-Reply-To: <25e44e70-eca6-5e48-fca1-844f76ea3a06@kernel.org> MIME-Version: 1.0 Received: from frank.li@vivo.com( [58.251.74.231) ] by ajax-webmail ( [127.0.0.1] ) ; Sat, 14 Aug 2021 10:08:25 +0800 (GMT+08:00) From: =?UTF-8?B?5p2O5oms6Z+s?= Date: Sat, 14 Aug 2021 10:08:25 +0800 (GMT+08:00) X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRoeGkxWSE8aSx9PSBhDTk pDVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kJHlYWEh9ZQU1OQkNDQkxPTEJON1dZDB4ZWUEPCQ4eV1kSHx4VD1lB WUc6PjY6ORw6LD8MEx9DUR1JK1EdFA8KFCJVSFVKTUlDQktNQktOQ01CVTMWGhIXVR0JGhUQVRcS Ow0SDRRVGBQWRVlXWRILWUFZTkNVSU5KVUxPVUlISllXWQgBWUFISkNKNwY+ X-HM-Tid: 0a7b426adfbed9aekuws81e3078009f Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pj4gV2UgY2FuJ3QgcmVtb3ZlIHN0YWNrIGZyb20gZGVwb3QsIGFzIHdlIHN0b3JlIHRoZW0gY29u dGlndW91c2x5IG9uZSBhZnRlcgo+PiBhbm90aGVyIGluIGEgY29udGlndW91cyBtZW1vcnkgYWxs b2NhdGlvbi4KPj4gCj4+IE9yIHdlIGNhbiBsaW1pdCB0aGUgcmVjb3JkZWQgc3RhY2sgbnVtYmVy Lgo+PiAKPj4gJCBncmVwIC1uciAiU0JJX05FRURfRlNDSyIgZnMvZjJmcy8gLS1pbmNsdWRlPSou YyAtLWluY2x1ZGU9Ki5oIHwgd2MgLWwKPj4gNTMKPj4gJCBncmVwIC1uciAiZjJmc19idWdfb24i IGZzL2YyZnMvIC0taW5jbHVkZT0qLmMgLS1pbmNsdWRlPSouaCB8IHdjIC1sCj4+IDEzNQo+Cj5J IGRpZG4ndCBsb29rIGludG8gZGV0YWlscyBvZiBzdGFja19kZXBvdF9zYXZlKCksIHR3byBzdGFj ayBoYW5kbGVzIGZyb20gYmVsb3cKPmNhbGwgcGF0aHMgd2lsbCBiZSB0aGUgc2FtZT8KPgo+LSBt b3ZlX2RhdGFfYmxvY2sKPiAgLSBmMmZzX3dhaXRfb25fcGFnZV93cml0ZWJhY2sKPiAgIC0gZjJm c19idWdfb24KPgo+LSByYV9kYXRhX2Jsb2NrCj4gIC0gZjJmc193YWl0X29uX3BhZ2Vfd3JpdGVi YWNrCj4gICAtIGYyZnNfYnVnX29uCj4KPklmIHRoZXkgaGF2ZSBkaWZmZXJlbnQgc3RhY2sgaGFu ZGxlcywgY29tYmluYXRpb24gbnVtYmVyIG9mCj5zZXRfc2JpX2ZsYWcoTkVFRF9GU0NLKS9mMmZz X2J1Z19vbiBhbmQgdGhlaXIgY2FsbGVycyB3aWxsIGJlIGZhciBtb3JlIHRoYW4gdHdvCj5odW5k cmVkLgo+CgpZZXMsIHRoZXNlIHdpbGwgYmUgdHdvIGRpZmZlcmVudCBzdGFja3MuIEluIHRoZSBt b3N0IGV4dHJlbWUgY2FzZSwgdGhlcmUgd2lsbCBiZSAxMDAwIChJIGd1ZXNzKSBkaWZmZXJlbnQg cGxhY2VzIHRvIHNldCBmc2NrPwpPciB3ZSBsaW1pdCB0aGUgbnVtYmVyIG9mIHJlY29yZGVkIHN0 YWNrcyB0byAxMD8Kd2hhdCBkbyB5b3UgdGhpbmsuIFRoZSBzdGFjayBkZXBvdCBkZXNpZ24gZG9l cyBub3QgY29uc2lkZXIgcmVtb3ZpbmcgdGhlIHN0YWNrIGZyb20gdGhlIGRlcG90LgoKTUJSLApZ YW5ndGFvDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849C0C4338F for ; Sat, 14 Aug 2021 02:08:40 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47A2160FC3 for ; Sat, 14 Aug 2021 02:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 47A2160FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1mEj6F-0001fV-QP; Sat, 14 Aug 2021 02:08:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mEj6D-0001fM-ST for linux-f2fs-devel@lists.sourceforge.net; Sat, 14 Aug 2021 02:08:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Date:From:MIME-Version:In-Reply-To:Subject:Cc:To: Message-ID:Content-Transfer-Encoding:Content-Type:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+4P5Pg1Zf3/UOYdU3qaWjUCwsxYsfEhzeC+CUAM0TM4=; b=QOhNwHxFL980UhW2wW9tX81gCc g3qLI4Aozj4DFOiBgXBXm4210z3I59IxrHpLJFe9lAU1i6Q6Q1tWpQOMb0KD4Gg2lCvWcOpJVrOeM 5VyGosD6Uv1Juq7NQYCQOosnKGttFPYndMFBeXIwhEm9j6BKTnEnT/+HANdH5aREfFjg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Date:From:MIME-Version:In-Reply-To:Subject:Cc:To:Message-ID: Content-Transfer-Encoding:Content-Type:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+4P5Pg1Zf3/UOYdU3qaWjUCwsxYsfEhzeC+CUAM0TM4=; b=RNdc8Lygk142AzxjR+coB4Wh9z Sk6Sa9L+8qSHlh55gHhqLEavrMfBAOA1z2EsqmjNkwQNDJxTx3mUwkaWRg4x3SLG7Tu7R2yOrQdfE Kf8Gn9eU+tinzVlo1U+QMBPaKY9Z2mWuxZm8C4oElHfpuOBJ1/k7fyITBSsy4PEQ79co=; Received: from mail-m176236.qiye.163.com ([59.111.176.236]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mEj69-005fiO-4q for linux-f2fs-devel@lists.sourceforge.net; Sat, 14 Aug 2021 02:08:37 +0000 Received: from vivo.com (localhost [127.0.0.1]) by mail-m176236.qiye.163.com (Hmail) with ESMTP id 81E3078009F; Sat, 14 Aug 2021 10:08:25 +0800 (CST) Message-ID: To: Chao Yu X-Priority: 3 X-Mailer: HMail Webmail Server V2.0 Copyright (c) 2016-163.com X-Originating-IP: 58.251.74.231 In-Reply-To: <25e44e70-eca6-5e48-fca1-844f76ea3a06@kernel.org> MIME-Version: 1.0 Received: from frank.li@vivo.com( [58.251.74.231) ] by ajax-webmail ( [127.0.0.1] ) ; Sat, 14 Aug 2021 10:08:25 +0800 (GMT+08:00) From: =?UTF-8?B?5p2O5oms6Z+s?= Date: Sat, 14 Aug 2021 10:08:25 +0800 (GMT+08:00) X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRoeGkxWSE8aSx9PSBhDTk pDVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kJHlYWEh9ZQU1OQkNDQkxPTEJON1dZDB4ZWUEPCQ4eV1kSHx4VD1lB WUc6PjY6ORw6LD8MEx9DUR1JK1EdFA8KFCJVSFVKTUlDQktNQktOQ01CVTMWGhIXVR0JGhUQVRcS Ow0SDRRVGBQWRVlXWRILWUFZTkNVSU5KVUxPVUlISllXWQgBWUFISkNKNwY+ X-HM-Tid: 0a7b426adfbed9aekuws81e3078009f X-Headers-End: 1mEj69-005fiO-4q Subject: Re: [f2fs-dev] =?utf-8?q?=5BPATCH_v5_1/2=5D_f2fs=3A_introduce_proc/f?= =?utf-8?q?s/f2fs/=3Cdev=3E/fsck=5Fstack_node?= X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net >> We can't remove stack from depot, as we store them contiguously one after >> another in a contiguous memory allocation. >> >> Or we can limit the recorded stack number. >> >> $ grep -nr "SBI_NEED_FSCK" fs/f2fs/ --include=*.c --include=*.h | wc -l >> 53 >> $ grep -nr "f2fs_bug_on" fs/f2fs/ --include=*.c --include=*.h | wc -l >> 135 > >I didn't look into details of stack_depot_save(), two stack handles from below >call paths will be the same? > >- move_data_block > - f2fs_wait_on_page_writeback > - f2fs_bug_on > >- ra_data_block > - f2fs_wait_on_page_writeback > - f2fs_bug_on > >If they have different stack handles, combination number of >set_sbi_flag(NEED_FSCK)/f2fs_bug_on and their callers will be far more than two >hundred. > Yes, these will be two different stacks. In the most extreme case, there will be 1000 (I guess) different places to set fsck? Or we limit the number of recorded stacks to 10? what do you think. The stack depot design does not consider removing the stack from the depot. MBR, Yangtao _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel